Plugin args enhancements #4278
Merged
Plugin args enhancements #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…directly If we're experimental, we should be using peer_exp_wiregen.h; wire/peer_wire.h does this for us. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This was fixed in 0.8.2. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: plugins: options to init are no longer given as strings if they are bool or int types (deprecated in 0.8.2).
"multi" means that specifying a parameter twice will append, not override. Multi args are always given as a JSON array, even if only one. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: Plugins: new "multi" field allows an option to be specified multiple times.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: Plugins: `start` command can now take plugin-specific parameters.
rustyrussell
force-pushed
the
guilt/plugin-args-enhance
branch
from
8996f89
to
1363333
Compare
|
ACK 1363333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.