Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittest cleanups #4233

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Unittest cleanups #4233

merged 2 commits into from
Dec 2, 2020

Conversation

rustyrussell
Copy link
Contributor

@rustyrussell rustyrussell commented Nov 29, 2020 •
edited
Loading

Built on top of #4227 so ignore all but last 2 commits.

Changelog-None

@cdecker
Copy link
Member

cdecker commented Nov 30, 2020

ACK 113b979

@rustyrussell
common: check for outstanding taken() pointers in common_shutdown.
feaea79 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
unittest: use common_setup / common_shutdown almost everywhere.
fbd10ba 
Avoids much cut & paste.  Some tests don't need any of it, but most
want at least some of this infrastructure.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell
Copy link
Contributor Author

Trivial rebase now predecessor merged

@rustyrussell rustyrussell merged commit ca2bd98 into ElementsProject:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdecker cdecker Awaiting requested review from cdecker

Assignees
No one assigned
Labels
cleanup testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustyrussell @cdecker