pyln: Plugin methods and hooks refuse to set results twice #4094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
reviewed
Sep 26, 2020
cdecker
force-pushed
the
pyln-plugin-duplicate-result
branch
from
a2a64a3
to
f836ef9
Compare
|
Folded in @m-schmoock's excellent fixups 👍 |
cdecker
force-pushed
the
pyln-plugin-duplicate-result
branch
from
f836ef9
to
f042f27
Compare
We had a couple of instances where a plugin would be killed by `lightningd` because we were returning a result of an exception twice, and it was hard to trace down the logic error in the user plugin that caused that. This patch adds a traceback the first time we return a result/exception, and raise an exception with a stacktrace of the first termination when a second one comes in. This can still terminate the plugin, but the programmer gets a clear indication where the result was set, and can potentially even recover from it. Changelog-Added: pyln: Plugin method and hook requests prevent the plugin developer from accidentally setting the result multiple times, and will raise an exception detailing where the result was first set.
cdecker
force-pushed
the
pyln-plugin-duplicate-result
branch
from
f042f27
to
8dee4eb
Compare
|
ACK 8dee4eb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a couple of instances where a plugin would be killed by
lightningdbecause we were returning a result of an exception twice, and it was hard to
trace down the logic error in the user plugin that caused that. This patch
adds a traceback the first time we return a result/exception, and raise an
exception with a stacktrace of the first termination when a second one comes
in.
This can still terminate the plugin, but the programmer gets a clear
indication where the result was set, and can potentially even recover from it.
Changelog-Added: pyln: Plugin method and hook requests prevent the plugin developer from accidentally setting the result multiple times, and will raise an exception detailing where the result was first set.