Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce log buffer from 100MB to 10MB #4087

Merged

Conversation

m-schmoock
Copy link
Collaborator

@m-schmoock m-schmoock commented Sep 24, 2020

The 100MB log buffer has been the biggest memory footprint for the daemon.
Keeping 10MB for emergency log dumps seems sufficient.
This has been mentioned in the last developer meeting.

Update: As @rustyrussell points out the log buffer always contains everything regardless of the config (io, esp and debug, ...). An average log entry has about 170Bytes, lets say 200Bytes with certain overhead. A well connected node may produce something like up to ~2 events per second depending on usage. Thus a 10MB buffer will last for ~8Hrs.

Changelog-Changed: In-memory log buffer reduced from 100MB to 10MB

The 100MB log buffer has been the biggest memory footprint for the daemon.
Keeping 10MB for emergency log dumps seems sufficient.
This has been mentioned in the last developer meeting.

Changelog-Changed: In-memory log buffer reduced from 100MB to 10MB
@m-schmoock m-schmoock marked this pull request as ready for review September 24, 2020 07:44
@rustyrussell
Copy link
Contributor

Except the log holds everything, esp debug logs and io logs (to subdaemons and all JSON RPC).

My log is 970266 seconds old, and it has 28886 entries (ignoring the "skipped" entries), and has eliminated 1150070. This equates to 1.2 log entries per second.

So I agree we should reduce this by 10, or even 100.

@rustyrussell
Copy link
Contributor

Ack b8cff9d

@rustyrussell rustyrussell merged commit 71381eb into ElementsProject:master Sep 26, 2020
@m-schmoock m-schmoock deleted the chore/reduce_logbuffer_to_10mb branch December 12, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants