Signet update (stolen from PR #4068) #4078

rustyrussell · 2020-09-23T01:27:49Z

No description provided.

…s as testnet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This lets us distinguish testnet from signet invoices, since they have the same prefix. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

kallewoof · 2020-09-23T01:54:01Z

Code ACK.

Compile errors (macbook on Catalina):

../../../libwally-core/src/internal.c:190:5: error: implicit declaration of function 'memset_s' is
      invalid in C99 [-Werror,-Wimplicit-function-declaration]
    memset_s(dest, len, 0, len);
    ^

May be unrelated -- I also see a number of other errors that seem to be ignored (e.g. sha256sum -- which is shasum -a256 on macs, btw).

dr-orlovsky · 2020-09-23T05:26:09Z

Confirm exactly same error on Macbook Pro with macOS Catalina

jsarenik · 2020-09-23T05:34:04Z

@rustyrussell could you please cherry-pick (squeez-in) b5764fc from my tree?

rustyrussell · 2020-09-23T07:31:13Z

Oh, and I should add a Changelog-Fixed: signet is now compatible with the bitcoin-core version...

Changelog-Fixed: Protocol: `signet` is now compatible with the final bitcoin-core version

kallewoof · 2020-09-23T10:52:25Z

~~Hm..~~ (Edit: configure issue; needed --network=signet)

lightningd also complains about fees a bunch:

2020-09-23T10:52:11.992Z UNUSUAL lightningd: Unable to estimate min_acceptable fees
2020-09-23T10:52:11.992Z UNUSUAL lightningd: Unable to estimate max_acceptable fees
2020-09-23T10:52:42.006Z UNUSUAL lightningd: Unable to estimate opening fees
2020-09-23T10:52:42.006Z UNUSUAL lightningd: Unable to estimate mutual_close fees
2020-09-23T10:52:42.006Z UNUSUAL lightningd: Unable to estimate unilateral_close fees
2020-09-23T10:52:42.006Z UNUSUAL lightningd: Unable to estimate delayed_to_us fees
2020-09-23T10:52:42.006Z UNUSUAL lightningd: Unable to estimate htlc_resolution fees
2020-09-23T10:52:42.006Z UNUSUAL lightningd: Unable to estimate penalty fees
2020-09-23T10:52:42.007Z UNUSUAL lightningd: Unable to estimate min_acceptable fees
2020-09-23T10:52:42.007Z UNUSUAL lightningd: Unable to estimate max_acceptable fees

jgriffiths · 2020-09-23T10:54:49Z

Compile errors (macbook on Catalina):
../../../libwally-core/src/internal.c:190:5: error: implicit declaration of function 'memset_s' is
invalid in C99 [-Werror,-Wimplicit-function-declaration]
memset_s(dest, len, 0, len);

This is fixed in wally master commit ElementsProject/libwally-core@16fb5cc if you want to update, or alternately you can remove CFLAGS=-std=c99 from external/Makefile.

dr-orlovsky

utACK 5ac88ce

jsarenik · 2020-09-23T13:29:33Z

Tested ACK 5ac88ce

kallewoof · 2020-09-23T13:59:38Z

I've tested what I could (funded a node), but don't know any peers I can connect to (jsarenik's node was gone by the time I tried it).

jsarenik · 2020-09-23T14:05:08Z

@kallewoof My node is up and I can leave it up as long as we agree. Otherwise it runs daily.

kallewoof · 2020-09-23T14:54:15Z

Tested ACK 5ac88ce

(OK, apparently my home network doesn't support IPv6 right now.

Anyway,) @jsarenik graciously gave me an IPv4 address, and that worked. I've funded a channel with his node, sent him several payments, and also used keysend a few times. He can't use it on me cause I'm behind a NAT atm.

The only issue I see is the incessant UNUSUAL lightningd: Unable to estimate XYZ fees messages. These basically take up most of the lightningd window, making it hard to spot other stuff going on.

dr-orlovsky · 2020-09-23T14:58:01Z

I've tested what I could (funded a node), but don't know any peers I can connect to (jsarenik's node was gone by the time I tried it).

@kallewoof try mine: 03787bddbba4bbae8133a164fa6db5de0f267e9bffe96695bc1e1c47a7b8e3d4ff@pandora.network:39735

I have also established channel with it + did funding and payments (from my notebook signet c-lightning). Everything working well (before the latest changes & bitcoin core update; with docker images I referenced above).

kallewoof · 2020-09-23T15:19:20Z

@dr-orlovsky I get

2020-09-23T15:18:50.248Z DEBUG 03787bddbba4bbae8133a164fa6db5de0f267e9bffe96695bc1e1c47a7b8e3d4ff-connectd: Failed connected out: 31.14.40.18:39735: Connection establishment: Bad file descriptor.

after about a minute of waiting.

carnhofdaki · 2020-09-23T15:55:42Z

Tested ACK

my node is at 02bcf115239d5c01b02d8f238bf736ffb23e0ef8ba73164b0fb3b82b83577190d4@dhouqtpq6sxrx4oopkawqp65ntpidwzgepv5g7azlbnl4m3owpwbriid.onion:1247

dr-orlovsky · 2020-09-23T19:37:19Z

@kallewoof strange. I think I need to upgate docker container with a new build from this version.

@carnhofdaki I am getting

orlovsky@pandora:~$ sightning-cli connect 02bcf115239d5c01b02d8f238bf736ffb23e0ef8ba73164b0fb3b82b83577190d4@dhouqtpq6sxrx4oopkawqp65ntpidwzgepv5g7azlbnl4m3owpwbriid.onion:1247
lightning-cli: Connecting to 'lightning-rpc': Connection refused

kallewoof · 2020-09-24T07:34:14Z

I should be available (sporadically) at

02823458ef60b73cef29eb3071d8f8062a452342014e66cadf9a35750352e5fa92@r5zmwuqr5kj7mufcyjtpgjggabw4fxwrj3ipd6i3f2afwddswnolx2yd.onion:9735

-- I think.

jsarenik · 2020-09-24T10:10:52Z

@kallewoof even though I can ping you, I can not keysend to you.

$ lightning-cli --signet ping 02823458ef60b73cef29eb3071d8f8062a452342014e66cadf9a35750352e5fa92
{
   "totlen": 132
}
$ lightning-cli --signet keysend 02823458ef60b73cef29eb3071d8f8062a452342014e66cadf9a35750352e5fa92 8304721sat
{
   "code": 210,
   "message": "Ran out of routes to try after 1 attempt: see `paystatus`",
   "attempts": [
      {
         "status": "failed",
         "failreason": "Error computing a route to 02823458ef60b73cef29eb3071d8f8062a452342014e66cadf9a35750352e5fa92: \"Could not find a route\" (205)",
         "partid": 0,
         "amount": "8304721000msat"
      }
   ]
}
$ lightning-cli --signet paystatus # nothing here
{
   "pay": []
}

All this running on node 03b9e6c1dec203f47efc95d003314d22cbb12a1324de4b091fe7d68f321a56322f where I opened a maximum size channel to you and it is in active state. Full connection string to this node which should be running 24/7 on latest lightningd is

IPv4: 03b9e6c1dec203f47efc95d003314d22cbb12a1324de4b091fe7d68f321a56322f@217.195.164.4:19738
onion: 03b9e6c1dec203f47efc95d003314d22cbb12a1324de4b091fe7d68f321a56322f@4il7h45anzwjdkaguk7b7w5gzftjky6upov2wnlv7zuzfdp3rbv5ppyd.onion:9735

And I will rather not mention this node's randomly generated alias here. Keeping it for some fun.

@kallewoof couldn't the problem with receiving be related to recent macOS issues? #3226

kallewoof · 2020-09-24T10:35:56Z

@jsarenik Could this be because I switched from IPv4 to Tor without closing our IPv4 channel first?

Edit: I didn't experience the issues described in #3226.

jsarenik · 2020-09-24T10:56:06Z

@kallewoof I think that should not be related. On the node where you opened a channel yesterday I see your node like this (trough listpeers):

    {
      "id": "02823458ef60b73cef29eb3071d8f8062a452342014e66cadf9a35750352e5fa92",
      "connected": true,
      "netaddr": [
        "[2a0b:f4c2::1]:61893"
      ],
      "features": "02aaa2",
      "channels": [
        {
          "state": "CHANNELD_NORMAL",
          "scratch_txid": "69a8f7952efaa592eac8230b57f5c6f302c0291c17f61809bfb1b73e79a6c2e2",
          "owner": "channeld",
          "short_channel_id": "4498x1x0",
          "direction": 1,
          "channel_id": "66eaf9ab8efd313a4a589fa66ddc28223b82de34ca3b2607be623c2600ebe4fe",
          "funding_txid": "fee4eb00263c62be07263bca34de823b2228dc6da69f584a3a31fd8eabf9ea66",
          "close_to_addr": "tb1qm2rqg8fftkf862yl5rqh0td08v360540jz04uk",
          "close_to": "0014da86041d295d927d289fa0c177adaf3b23a7d2af",
          "private": false,
          "features": [
            "option_static_remotekey"
          ],
          "funding_allocation_msat": {
            "02823458ef60b73cef29eb3071d8f8062a452342014e66cadf9a35750352e5fa92": 16777215000,
            "03544abbc36ef2633fcfbc4ab3b038ca91b38fa475b760c2c76c1cb0425d15c890": 0
          },
          "funding_msat": {
            "02823458ef60b73cef29eb3071d8f8062a452342014e66cadf9a35750352e5fa92": "16777215000msat",
            "03544abbc36ef2633fcfbc4ab3b038ca91b38fa475b760c2c76c1cb0425d15c890": "0msat"
          },
          "msatoshi_to_us": 10000201,
          "to_us_msat": "10000201msat",
          "msatoshi_to_us_min": 0,
          "min_to_us_msat": "0msat",
          "msatoshi_to_us_max": 10000201,
          "max_to_us_msat": "10000201msat",
          "msatoshi_total": 16777215000,
          "total_msat": "16777215000msat",
          "dust_limit_satoshis": 546,
          "dust_limit_msat": "546000msat",
          "max_htlc_value_in_flight_msat": 18446744073709552000,
          "max_total_htlc_in_msat": "18446744073709551615msat",
          "their_channel_reserve_satoshis": 167772,
          "their_reserve_msat": "167772000msat",
          "our_channel_reserve_satoshis": 167772,
          "our_reserve_msat": "167772000msat",
          "spendable_msatoshi": 0,
          "spendable_msat": "0msat",
          "receivable_msatoshi": 4294967295,
          "receivable_msat": "4294967295msat",
          "htlc_minimum_msat": 0,
          "minimum_htlc_in_msat": "0msat",
          "their_to_self_delay": 6,
          "our_to_self_delay": 6,
          "max_accepted_htlcs": 483,
          "status": [
            "CHANNELD_NORMAL:Reconnected, and reestablished.",
            "CHANNELD_NORMAL:Funding transaction locked. Channel announced."
          ],
          "in_payments_offered": 3,
          "in_msatoshi_offered": 10000201,
          "in_offered_msat": "10000201msat",
          "in_payments_fulfilled": 3,
          "in_msatoshi_fulfilled": 10000201,
          "in_fulfilled_msat": "10000201msat",
          "out_payments_offered": 0,
          "out_msatoshi_offered": 0,
          "out_offered_msat": "0msat",
          "out_payments_fulfilled": 0,
          "out_msatoshi_fulfilled": 0,
          "out_fulfilled_msat": "0msat",
          "htlcs": []
        }
      ]
    },

dr-orlovsky · 2020-09-24T19:15:34Z

@jsarenik channel funded.

So yes, prev build was just not working with the new one

And yes, c-lightning fails to estimate fees on signet (I assume that's ok?)

kallewoof · 2020-09-25T05:03:37Z

And yes, c-lightning fails to estimate fees on signet (I assume that's ok?)

Yeah, this is the case for bitcoin core as well, and applies to regtest as well.

rustyrussell added 2 commits September 23, 2020 10:43

bitcoin/chainparams: signet uses the same P2PKH and P2SH version byte…

9a09177

…s as testnet. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

bolt11: have caller supply preferred chain.

f8c8978

This lets us distinguish testnet from signet invoices, since they have the same prefix. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

rustyrussell mentioned this pull request Sep 23, 2020

Updating signet chainparams for the latest PoW fix #4068

Closed

rustyrussell mentioned this pull request Sep 23, 2020

MacOS compilation issue? ElementsProject/libwally-core#229

Closed

dr-orlovsky and others added 2 commits September 23, 2020 17:02

Updating signet chainparams for the latest PoW fix

d9bce97

Changelog-Fixed: Protocol: `signet` is now compatible with the final bitcoin-core version

Update comment regarding signet using tb now

5ac88ce

rustyrussell force-pushed the pr-4068 branch from 34e53ec to 5ac88ce Compare September 23, 2020 07:32

dr-orlovsky approved these changes Sep 23, 2020

View reviewed changes

rustyrussell merged commit b1355bf into ElementsProject:master Sep 23, 2020

rustyrussell added the Optech Make Me Famous! Look! Look! Look! COOL NEW FEATURE! label Sep 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Signet update (stolen from PR #4068) #4078

Signet update (stolen from PR #4068) #4078

rustyrussell commented Sep 23, 2020

kallewoof commented Sep 23, 2020 •

edited

Loading

dr-orlovsky commented Sep 23, 2020

jsarenik commented Sep 23, 2020

rustyrussell commented Sep 23, 2020

kallewoof commented Sep 23, 2020 •

edited

Loading

jgriffiths commented Sep 23, 2020

dr-orlovsky left a comment

jsarenik commented Sep 23, 2020 •

edited

Loading

kallewoof commented Sep 23, 2020

jsarenik commented Sep 23, 2020

kallewoof commented Sep 23, 2020 •

edited

Loading

dr-orlovsky commented Sep 23, 2020

kallewoof commented Sep 23, 2020

carnhofdaki commented Sep 23, 2020

dr-orlovsky commented Sep 23, 2020

kallewoof commented Sep 24, 2020 •

edited

Loading

jsarenik commented Sep 24, 2020

kallewoof commented Sep 24, 2020 •

edited

Loading

jsarenik commented Sep 24, 2020

dr-orlovsky commented Sep 24, 2020

kallewoof commented Sep 25, 2020

Signet update (stolen from PR #4068) #4078

Signet update (stolen from PR #4068) #4078

Conversation

rustyrussell commented Sep 23, 2020

kallewoof commented Sep 23, 2020 • edited Loading

dr-orlovsky commented Sep 23, 2020

jsarenik commented Sep 23, 2020

rustyrussell commented Sep 23, 2020

kallewoof commented Sep 23, 2020 • edited Loading

jgriffiths commented Sep 23, 2020

dr-orlovsky left a comment

Choose a reason for hiding this comment

jsarenik commented Sep 23, 2020 • edited Loading

kallewoof commented Sep 23, 2020

jsarenik commented Sep 23, 2020

kallewoof commented Sep 23, 2020 • edited Loading

dr-orlovsky commented Sep 23, 2020

kallewoof commented Sep 23, 2020

carnhofdaki commented Sep 23, 2020

dr-orlovsky commented Sep 23, 2020

kallewoof commented Sep 24, 2020 • edited Loading

jsarenik commented Sep 24, 2020

kallewoof commented Sep 24, 2020 • edited Loading

jsarenik commented Sep 24, 2020

dr-orlovsky commented Sep 24, 2020

kallewoof commented Sep 25, 2020

kallewoof commented Sep 23, 2020 •

edited

Loading

kallewoof commented Sep 23, 2020 •

edited

Loading

jsarenik commented Sep 23, 2020 •

edited

Loading

kallewoof commented Sep 23, 2020 •

edited

Loading

kallewoof commented Sep 24, 2020 •

edited

Loading

kallewoof commented Sep 24, 2020 •

edited

Loading