openchannel: make openchannel hook chainable #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-schmoock
force-pushed
the
openchannel-hook-chainable
branch
from
11b6257
to
aecba6f
Compare
|
Definitely want this! |
m-schmoock
force-pushed
the
openchannel-hook-chainable
branch
11 times, most recently
from
d411ff3
to
1666f35
Compare
niftynei
reviewed
Aug 28, 2020
m-schmoock
force-pushed
the
openchannel-hook-chainable
branch
8 times, most recently
from
2612dbb
to
b98e80d
Compare
m-schmoock
force-pushed
the
openchannel-hook-chainable
branch
from
b98e80d
to
dbbad65
Compare
cdecker
reviewed
Sep 6, 2020
cdecker
approved these changes
Sep 6, 2020
|
ACK dbbad65 |
This will make the `openchannel_hook` chainable. Logic is as follows: - The first plugin that rejects terminates the chain - If more than one plugin uses the `close_to` parameter, take the first value and log_unusual for the others. Changelog-Added: openchannel_hook is now chainable
m-schmoock
force-pushed
the
openchannel-hook-chainable
branch
from
dbbad65
to
e006d19
Compare
|
Thanks for the fixup @m-schmoock, excellent work 👍 ACK e006d19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required to make the decomission feature possible: #3550
Status: Done. The code is functional and does not seem to have bugs. There is a strange workaround in
tests/test_plugin.pytest_openchannel_hook_chainingwhere it needs to check for actual hook execution order in order to have the test stable. this is caused by the way hooks are currently registered, see #4005 for details about this.Question: Currently this change will just log
UNUSUALif a second hook also tries to set aclose_toaddress and continues normal operation. Question: Is this sufficient or should rather want tofatalsuch plugin setups.