Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routehints get ignored if invoice >10,000 sats #3908

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

ZmnSCPxj
Copy link
Contributor

@ZmnSCPxj ZmnSCPxj commented Aug 6, 2020

This PR fixes that problem.

@ZmnSCPxj ZmnSCPxj requested a review from cdecker as a code owner August 6, 2020 05:22
@ZmnSCPxj ZmnSCPxj added the bug label Aug 6, 2020
@ZmnSCPxj ZmnSCPxj force-pushed the fix-routehints-ignored branch from 6baf44c to f9396b8 Compare August 6, 2020 05:27
Changelog-Fixed: pay: Fixed a bug where routehints would be ignored if the payment exceeded 10,000 satoshi. This is particularly bad if the payee is only reachable via routehints in an invoice.
@ZmnSCPxj ZmnSCPxj force-pushed the fix-routehints-ignored branch from f9396b8 to f521fc6 Compare August 6, 2020 05:28
@cdecker
Copy link
Member

cdecker commented Aug 6, 2020

ACK f521fc6

@cdecker cdecker merged commit 4fde456 into ElementsProject:master Aug 6, 2020
@ZmnSCPxj ZmnSCPxj deleted the fix-routehints-ignored branch August 7, 2020 00:40
@ZmnSCPxj ZmnSCPxj mentioned this pull request Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants