openingd/openingd.c: Fix a mild deviation from BOLT#2. #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep. It fixes. @ZmnSCPxj |
|
Thank you for the confirmation @joemphilips . Just waiting on Travis and ACKs. |
|
Rebased on top of master. |
Fixes: ElementsProject#3815 Changelog-Fixed: Fixed a deviation from BOLT#2: if both nodes advertised `option_upfront_shutdown_script` feature: MUST include ... a zero-length `shutdown_scriptpubkey`.
|
ACK 629fb48 |
|
github somehow lost all the checks, weird. Anyway:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3815
Changelog-Fixed: Fixed a deviation from BOLT#2: if both nodes advertised
option_upfront_shutdown_scriptfeature: MUST include ... a zero-lengthshutdown_scriptpubkey.@joemphilips can you check if this fixes #3815?