Bitcoin: fail immediately if we lose connection to our backend #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
This in addition removes the init fixed timeout hack. Changelog-fixed: We now *always* die if our Bitcoin backend failed unexpectedly. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
They are already logged both in bcli, and in lightningd. This just adds a lot of noise to the logs. We keep successed attempts though for the tests. Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
darosior
force-pushed
the
reliable_bitcoin_backend
branch
from
e9533d3
to
2c1f300
Compare
|
ACK 2c1f300 |
|
In general, I think we should die if a static plugin dies. WRT release, it's @niftynei's call here, as Release Captain for 0.8.2. IMHO, if we were doing another rc anyway, I'd put this in, but wouldn't do an rc4 for this alone. |
darosior
added a commit
to darosior/plugins
that referenced
this pull request
Apr 30, 2020
The exception might be excepted, and we would continue execution. This works better after ElementsProject/lightning#3675 which will immediately make lightningd die if we exit Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
cdecker
pushed a commit
to lightningd/plugins
that referenced
this pull request
Apr 30, 2020
The exception might be excepted, and we would continue execution. This works better after ElementsProject/lightning#3675 which will immediately make lightningd die if we exit Signed-off-by: Antoine Poinsot <darosior@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes \ #3571, but I'd like to double check with @whitslack before auto closing the issue.
This comports two drive-by fixes in addition which I remarked while debugging #3571.