-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken tests on elements and various cleanups #3568
Commits on Mar 19, 2020
-
pytest: Actually make sure that the direcory exists
Some tests may not spawn a node at all, so make sure that our assumption that the directory exists in the fixture cleanup is correct by creating the directory.
Configuration menu - View commit details
-
Copy full SHA for b5a41f9 - Browse repository at this point
Copy the full SHA b5a41f9View commit details
Commits on Mar 23, 2020
-
tx: Strengthen transaction construction checks
We roll the `elements_add_fee_output` function and the cropping of overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed to be the final cleanup and compaction step before a tx can be sent to bitcoin or passed off to other daemons. This is the cleanup promised in ElementsProject#3491
Configuration menu - View commit details
-
Copy full SHA for 3eaa7a5 - Browse repository at this point
Copy the full SHA 3eaa7a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8549308 - Browse repository at this point
Copy the full SHA 8549308View commit details -
pyln: Migrate remaining uses of the deprecated pylightning module
`pylightning` is not much more than an alias for `pyln-client`, so this removes the need to install that as well just to run the tests.
Configuration menu - View commit details
-
Copy full SHA for 9aeb501 - Browse repository at this point
Copy the full SHA 9aeb501View commit details -
pyln-testing: Print a list of files if we can't remove the test dir
For some reason we fail to remove the test directory in some cases. My hypothesis is that it is a daemon that is not completely shut down yet, and still writes to the directory. This commit intercepts the error, prints any files in the directory and re-raises the error. This should allow us to debug the reappears.
Configuration menu - View commit details
-
Copy full SHA for 374d4ee - Browse repository at this point
Copy the full SHA 374d4eeView commit details -
pytest: Configure logging in a fixture to match stdout capturing
pytest captures the output by monkey patching out `sys.stdout`. This may conflict with our use of `sys.stdout` when configuring logging, resulting in the "Write to closed file" issue that is spamming the logs. By making the logging configuration a fixture hopefully we always use the correct stdout (after pytest has monkey-patched it).
Configuration menu - View commit details
-
Copy full SHA for f5bb709 - Browse repository at this point
Copy the full SHA f5bb709View commit details -
pytest: Unbreak the test_feerate_spam test for elementsd
Looking for specific feerates, but not adjusting the amounts involved doesn't work.
Configuration menu - View commit details
-
Copy full SHA for 136ec7a - Browse repository at this point
Copy the full SHA 136ec7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 378037c - Browse repository at this point
Copy the full SHA 378037cView commit details -
json-rpc: Fix test_txprepare if running with postgres
Postgres does not guarantee that the insertion order is the returned order, which leads us to skip outputs that have already been stolen onto the selected utxos set, but not added to it because it isn't confirmed. This may also happen with sqlite3 though it's a lot rarer in that case.
Configuration menu - View commit details
-
Copy full SHA for 1c3037f - Browse repository at this point
Copy the full SHA 1c3037fView commit details -
pytest: Fix test_closing_fee regression in elements
Constants once again.
Configuration menu - View commit details
-
Copy full SHA for c85988f - Browse repository at this point
Copy the full SHA c85988fView commit details