Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle blockheight disagreement between us and payee #3376

Merged
merged 6 commits into from
Jan 21, 2020
Merged

Handle blockheight disagreement between us and payee #3376

merged 6 commits into from
Jan 21, 2020

Commits on Jan 15, 2020

  1. common/json.c: Implement json_to_u32.

    @ZmnSCPxj
    ZmnSCPxj committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    021fd29 View commit details
    Browse the repository at this point in the history

  2. lightningd/peer_control.c: Implement waitblockheight. 

    This is needed to fully implement handling of blockheight disagreements
between us and payee.
If payee believes the blockheight is higher than ours, then `pay`
should wait for our node to achieve that blockheight.

Changelog-Add: Implement `waitblockheight` to wait for a specific blockheight.
    @ZmnSCPxj
    ZmnSCPxj committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    f9decf1 View commit details
    Browse the repository at this point in the history

  3. pay: Factor out execution of getroute from starting of payment atte… 

    …mpt.
    @ZmnSCPxj
    ZmnSCPxj committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    2d58e10 View commit details
    Browse the repository at this point in the history

  4. pay: Implement tracking of blockheight for starting payment attempts.

    @ZmnSCPxj
    ZmnSCPxj committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    5ca3727 View commit details
    Browse the repository at this point in the history

  5. test_pay.py: Add test for blockheight disagreement.

    @ZmnSCPxj
    ZmnSCPxj committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    637ec60 View commit details
    Browse the repository at this point in the history

  6. pay: Implement retry in case of final CLTV being too soon for receiver. 

    Changelog-Fixed: Detect a previously non-permanent error (`final_cltv_too_soon`) that has been merged into a permanent error (`incorrect_or_unknown_payment_details`), and retry that failure case in `pay`.
    @ZmnSCPxj
    ZmnSCPxj committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    5b7c215 View commit details
    Browse the repository at this point in the history