Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: listtransactions crash #3231 #3256

Merged

Conversation

m-schmoock
Copy link
Collaborator

@m-schmoock m-schmoock commented Nov 12, 2019

Fixes #3231

Ready for Review and Merge

@m-schmoock m-schmoock changed the title pytest: add test for raising listtransactions after funding fix: issue #3231 Nov 12, 2019
@m-schmoock m-schmoock changed the title fix: issue #3231 fix: listtransactions crash #3231 Nov 12, 2019
@m-schmoock m-schmoock force-pushed the fix/fundchannel_listtransaction branch from 9392086 to cfd4c2d Compare November 14, 2019 09:56
Copy link
Member

@cdecker cdecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap the order of the two commits? Otherwise testing after applying the first one would fail (bisectability).

wallet/wallet.c Outdated Show resolved Hide resolved
wallet/wallet.c Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@m-schmoock m-schmoock force-pushed the fix/fundchannel_listtransaction branch from 170a89a to 68a8c73 Compare November 14, 2019 19:33
@m-schmoock m-schmoock force-pushed the fix/fundchannel_listtransaction branch from 68a8c73 to b4c3be9 Compare November 14, 2019 19:34
@m-schmoock
Copy link
Collaborator Author

okay, done from my side...

@rustyrussell rustyrussell merged commit d7609e6 into ElementsProject:master Nov 15, 2019
@m-schmoock m-schmoock deleted the fix/fundchannel_listtransaction branch November 15, 2019 06:07
@cdecker
Copy link
Member

cdecker commented Nov 15, 2019

Awesome, thanks @m-schmoock 👍

@m-schmoock
Copy link
Collaborator Author

@cdecker Yes, but it can now raise consistency assertions on 'older' databases:

#3265

Ideas? I can fix that too :D ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

listtransactions crash
3 participants