Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc api: Same fee limit handling for keysend and pay #7227

Closed
michaelWuensch opened this issue Apr 16, 2024 · 1 comment · Fixed by #7653
Closed

grpc api: Same fee limit handling for keysend and pay #7227

michaelWuensch opened this issue Apr 16, 2024 · 1 comment · Fixed by #7653

Comments

@michaelWuensch
Copy link

Issue

The handling of fee limits is inconsistent on different api endpoints.
The lightning-pay api endpoint exposes maxfee, maxfeepercent and exemptfee fee as parameters. (https://docs.corelightning.org/reference/lightning-pay)
The lightning-keysend api enpoint only exposes maxfeepercent and exemptfee. (https://docs.corelightning.org/reference/lightning-keysend)

Please add maxfee to lightning-keysend to simplify and unify api handling.
@michaelWuensch michaelWuensch mentioned this issue Apr 16, 2024
Closed
@BitcoinJiuJitsu
Copy link

BitcoinJiuJitsu commented Jun 25, 2024 •
edited
Loading

Open CLN bounty on this:
https://community.sphinx.chat/p/clt2n32tu2rjujq1jn6g/bounties/2160/0

@s373nZ s373nZ mentioned this issue Sep 9, 2024
Merged
7 tasks
s373nZ added a commit to s373nZ/lightning that referenced this issue Sep 17, 2024
@s373nZ
keysend: Add maxfee to keysend for consistency with pay. ([Elements…
5fed120 
…Project#7227])

Changelog-Added: keysend: Add `maxfee` to keysend for consistency with pay. ([ElementsProject#7227])
s373nZ added a commit to s373nZ/lightning that referenced this issue Sep 20, 2024
@s373nZ
keysend: Add maxfee to keysend for consistency with pay. ([Elements…
7291d66 
…Project#7227])

Changelog-Added: keysend: Add `maxfee` to keysend for consistency with pay. ([ElementsProject#7227])
s373nZ added a commit to s373nZ/lightning that referenced this issue Sep 21, 2024
@s373nZ
keysend: Add maxfee to keysend for consistency with pay. ([Elements…
10af5ea 
…Project#7227])

Changelog-Added: keysend: Add `maxfee` to keysend for consistency with pay. ([ElementsProject#7227])
s373nZ added a commit to s373nZ/lightning that referenced this issue Sep 22, 2024
@s373nZ
keysend: Add maxfee to keysend for consistency with pay. ([Elements…
0772906 
…Project#7227])

Changelog-Added: keysend: Add `maxfee` to keysend for consistency with pay. ([ElementsProject#7227])
s373nZ added a commit to s373nZ/lightning that referenced this issue Sep 24, 2024
@s373nZ
keysend: Add maxfee to keysend for consistency with pay. ([Elements…
fdd60db 
…Project#7227])

Changelog-Added: keysend: Add `maxfee` to keysend for consistency with pay. ([ElementsProject#7227])
cdecker pushed a commit that referenced this issue Oct 14, 2024
@s373nZ @cdecker
keysend: Add maxfee to keysend for consistency with pay. ([#7227])
f9e28b9 
Changelog-Added: keysend: Add `maxfee` to keysend for consistency with pay. ([#7227])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

keysend: Add maxfee to keysend for consistency with pay s373nZ/lightning
2 participants
@michaelWuensch @BitcoinJiuJitsu