Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to upgrade to latest, bug in new database field #6016

Closed
niftynei opened this issue Feb 15, 2023 · 0 comments · Fixed by #6018
Closed

Unable to upgrade to latest, bug in new database field #6016

niftynei opened this issue Feb 15, 2023 · 0 comments · Fixed by #6018
Labels
bug
Milestone
v23.02

Comments

@niftynei
Copy link
Contributor

niftynei commented Feb 15, 2023 •
edited
Loading 

Feb 15 16:02:12 citrine lightningd[902093]: Accessing a null column lease_satoshi/15 in query SELECT  funding_tx_id, funding_tx_outnum, funding_feerate, funding_satoshi, our_funding_satoshi, funding_psbt, last_tx, last_sig, funding_tx_remote_sigs_received, lease_expiry, lease_commit_sig, lease_chan_max_msat, lease_chan_max_ppt, lease_blockheight_start, lease_fee, lease_satoshi FROM channel_funding_inflights WHERE channel_id = ? ORDER BY funding_feerate

Got this log when attempting to upgrade to v23.02rc2. I believe it's because no default was set on the column definition.

    {SQL("ALTER TABLE channel_funding_inflights ADD COLUMN lease_satoshi BIGINT;"), NULL},
@niftynei niftynei added the bug label Feb 15, 2023
@endothermicdev endothermicdev added this to the v23.02 milestone Feb 15, 2023
niftynei added a commit to niftynei/lightning that referenced this issue Feb 15, 2023
@niftynei
db-fix: update NULL lease_satoshi fields to zero
5d03f6f 
Missed a DEFAULT in the db clause.

Feb 15 16:02:12 citrine lightningd[902093]: Accessing a null column lease_satoshi/15 in query SELECT  funding_tx_id, funding_tx_outnum, funding_feerate, funding_satoshi, our_funding_satoshi, funding_psbt, last_tx, last_sig, funding_tx_remote_sigs_received, lease_expiry, lease_commit_sig, lease_chan_max_msat, lease_chan_max_ppt, lease_blockheight_start, lease_fee, lease_satoshi FROM channel_funding_inflights WHERE channel_id = ? ORDER BY funding_feerate

Fixes ElementsProject#6016
@niftynei niftynei mentioned this issue Feb 15, 2023
Merged
endothermicdev pushed a commit that referenced this issue Feb 16, 2023
@niftynei @endothermicdev
db-fix: update NULL lease_satoshi fields to zero
e315f30 
Missed a DEFAULT in the db clause.

Feb 15 16:02:12 citrine lightningd[902093]: Accessing a null column lease_satoshi/15 in query SELECT  funding_tx_id, funding_tx_outnum, funding_feerate, funding_satoshi, our_funding_satoshi, funding_psbt, last_tx, last_sig, funding_tx_remote_sigs_received, lease_expiry, lease_commit_sig, lease_chan_max_msat, lease_chan_max_ppt, lease_blockheight_start, lease_fee, lease_satoshi FROM channel_funding_inflights WHERE channel_id = ? ORDER BY funding_feerate

Fixes #6016
ddustin pushed a commit to ddustin/lightning that referenced this issue Apr 11, 2023
@niftynei @ddustin
db-fix: update NULL lease_satoshi fields to zero
ca446c8 
Missed a DEFAULT in the db clause.

Feb 15 16:02:12 citrine lightningd[902093]: Accessing a null column lease_satoshi/15 in query SELECT  funding_tx_id, funding_tx_outnum, funding_feerate, funding_satoshi, our_funding_satoshi, funding_psbt, last_tx, last_sig, funding_tx_remote_sigs_received, lease_expiry, lease_commit_sig, lease_chan_max_msat, lease_chan_max_ppt, lease_blockheight_start, lease_fee, lease_satoshi FROM channel_funding_inflights WHERE channel_id = ? ORDER BY funding_feerate

Fixes ElementsProject#6016
gkrizek pushed a commit to voltagecloud/lightning that referenced this issue Apr 26, 2023
@niftynei @gkrizek
db-fix: update NULL lease_satoshi fields to zero
d3c79de 
Missed a DEFAULT in the db clause.

Feb 15 16:02:12 citrine lightningd[902093]: Accessing a null column lease_satoshi/15 in query SELECT  funding_tx_id, funding_tx_outnum, funding_feerate, funding_satoshi, our_funding_satoshi, funding_psbt, last_tx, last_sig, funding_tx_remote_sigs_received, lease_expiry, lease_commit_sig, lease_chan_max_msat, lease_chan_max_ppt, lease_blockheight_start, lease_fee, lease_satoshi FROM channel_funding_inflights WHERE channel_id = ? ORDER BY funding_feerate

Fixes ElementsProject#6016
ddustin pushed a commit to ddustin/lightning that referenced this issue May 12, 2023
@niftynei @ddustin
db-fix: update NULL lease_satoshi fields to zero
43bdb48 
Missed a DEFAULT in the db clause.

Feb 15 16:02:12 citrine lightningd[902093]: Accessing a null column lease_satoshi/15 in query SELECT  funding_tx_id, funding_tx_outnum, funding_feerate, funding_satoshi, our_funding_satoshi, funding_psbt, last_tx, last_sig, funding_tx_remote_sigs_received, lease_expiry, lease_commit_sig, lease_chan_max_msat, lease_chan_max_ppt, lease_blockheight_start, lease_fee, lease_satoshi FROM channel_funding_inflights WHERE channel_id = ? ORDER BY funding_feerate

Fixes ElementsProject#6016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v23.02
Development

Successfully merging a pull request may close this issue.

db-fix: update NULL lease_satoshi fields to zero niftynei/lightning
2 participants
@niftynei @endothermicdev