lightning-cli pay and keysend broken

[mb300sd]

Issue and Steps to Reproduce

lightning-cli keysend ************************************ 0.04btc
lightning-cli: reading response: socket closed

lightning-cli pay lnbc************************************************
lightning-cli: reading response: socket closed

getinfo output

"version": "v0.10.1-313-g0f0a77e",
"blockheight": 706201,
"network": "bitcoin",

[vincenzopalazzo]

Do you have some information in your log file?

[mb300sd]

2021-10-23T15:54:21.045Z **BROKEN** lightningd: Error executing statement: ERROR:  duplicate key value violates unique constraint "payments_pkey1"?DETAIL:  Key (id)=(5) already exists.?
2021-10-23T15:54:21.061Z **BROKEN** lightningd: FATAL SIGNAL 6 (version v0.10.1-313-g0f0a77e)
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: common/daemon.c:46 (crashdump) 0x55f4b1f5d2b8
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f0a94f4583f
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f0a94f457bb
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f0a94f30534
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: lightningd/log.c:804 (fatal) 0x55f4b1f1da10
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: wallet/db.c:2180 (db_exec_prepared_v2) 0x55f4b1f42a6f
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: wallet/db.c:2165 (db_exec_prepared_v2) 0x55f4b1f42a6f
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: wallet/wallet.c:3019 (wallet_payment_store) 0x55f4b1f4be89
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: lightningd/pay.c:522 (payment_store) 0x55f4b1f2a60e
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: lightningd/peer_htlcs.c:1641 (update_out_htlc) 0x55f4b1f31b18
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: lightningd/peer_htlcs.c:1761 (peer_sending_commitsig) 0x55f4b1f335b2
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: lightningd/channel_control.c:466 (channel_msg) 0x55f4b1f06523
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: lightningd/subd.c:557 (sd_msg_read) 0x55f4b1f3d322
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:59 (next_plan) 0x55f4b1fa6cf6
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:417 (io_ready) 0x55f4b1fa75da
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: ccan/ccan/io/poll.c:453 (io_loop) 0x55f4b1fa8e17
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: lightningd/io_loop_with_timers.c:21 (io_loop_with_timers) 0x55f4b1f184de
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: lightningd/lightningd.c:1163 (main) 0x55f4b1efe35c
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x7f0a94f3209a
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0x55f4b1effaf9
2021-10-23T15:54:21.061Z **BROKEN** lightningd: backtrace: (null):0 ((null)) 0xffffffffffffffff

[mb300sd]

Looks like a database issue. I'm running on postgres.

[vincenzopalazzo]

Looks like a database issue. I'm running on postgres.

Right, this is a violation key error, basically. I will try to look into it.

[cdecker]

Looks a bit like a postgresql regression, and I have a hunch what it might be. Could you try and execute the query in #4887 (comment), that should help us determine whether my hunch is correct

[cdecker]

I marked this as a duplicate of #4887 despite this being the first variant, I hope that's ok, but we have a bit more context on there.

[mb300sd]

That's fine. I was drinking heavily when I found the problem, and just posted an issue without debugging myself first.

[cdecker]

See #4894 for a fix. If I can confirm that this addresses the issue I can tag rc2 tomorrow ^^