Skip to content

Commit

Permalink
review 2/2: Use generic query to make the code more readable.
Browse files Browse the repository at this point in the history
Suggested by @cdecker.

P.S: Also this include an API refactoring from my previous solution, also this it is suggested by @cdecker.

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
  • Loading branch information
vincenzopalazzo committed Sep 14, 2021
1 parent a2a6d08 commit 22d728d
Show file tree
Hide file tree
Showing 12 changed files with 219 additions and 894 deletions.
6 changes: 3 additions & 3 deletions doc/lightning-listsendpays.7

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions doc/lightning-listsendpays.7.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ lightning-listsendpays -- Low-level command for querying sendpay status
SYNOPSIS
--------

**listsendpays** \[*bolt11*\] \[*payment\_hash*\] [\*status*\]
**listsendpays** \[*bolt11*\] \[*payment\_hash*\] \[*status*\]

DESCRIPTION
-----------

The **listsendpays** RPC command gets the status of all *sendpay*
commands (which is also used by the *pay* command), or with *bolt11* or
*payment\_hash* limits results to that specific payment. You cannot
specify both. It is possible filter the payments also by status.
specify both. It is possible filter the payments also by *status*.

Note that in future there may be more than one concurrent *sendpay*
command per *pay*, so this command should be used with caution.
Expand Down
2 changes: 1 addition & 1 deletion wallet/db.c
Original file line number Diff line number Diff line change
Expand Up @@ -1697,7 +1697,7 @@ void db_bind_preimage(struct db_stmt *stmt, int pos, const struct preimage *p)

void db_bind_sha256(struct db_stmt *stmt, int pos, const struct sha256 *s)
{
db_bind_blob(stmt, pos, s->u.u8, sizeof(struct sha256));
db_bind_blob(stmt, pos, s->u.u8, sizeof(struct sha256));
}

void db_bind_sha256d(struct db_stmt *stmt, int pos, const struct sha256_double *s)
Expand Down
156 changes: 5 additions & 151 deletions wallet/db_postgres_sqlgen.c

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 22d728d

Please sign in to comment.