Skip to content

Commit

Permalink
Clean Up Case #5 in Tor Documentation
Browse files Browse the repository at this point in the history 
Case 5 in the Tor documentation currently states that if you use `--bind-addr=autotor:127.0.0.1:9051`, you can get your onion address by running `lightning-cli getinfo`. I have not found that to be the case; with that flag no onion address will be generated.

On the other hand, if `--addr=autotor:127.0.0.1:9051` is used instead, an onion address is generated and `lightning-cli getinfo` behaves as the docs say.
  • Loading branch information
@JeffVandrewJr @niftynei
JeffVandrewJr authored and niftynei committed Mar 30, 2019
1 parent 901bd7c commit 02ddeed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doc/TOR.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ or `--addr=your.onionAddress:port` if you are NOT on an internal network.
In this case it is difficult to track the node.
You specify just:
```
--bind-addr=yourInternalIPAddress:port --bind-addr=autotor:127.0.0.1:9051
--bind-addr=yourInternalIPAddress:port --addr=autotor:127.0.0.1:9051
```
In the `lightningd` command line.

Expand Down

13 comments on commit 02ddeed

@gabridome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--bind-address SHOULD work with autotor.
Please take a look at #2183 (solved into #2192).

If nothing has changed, it is not an issue in the documentation, it is an issue to be opened regarding the code (or maybe reopening #2183?). @Saibato @cdecker

@Saibato
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabridome : good catch +1: That PR is 🤦‍♀️ I am speechless

NACK #2514

The wording should have been changed to "is hidden and not announced and no longer with simple getinfo visible" but to suggest --addr= makes it less track able, when the opposite is the case is suboptimal

Changes regarding Tor or Tor Doc should from now on, if not critical be open for more than one Day before merged. Shame on me that I don't read Docs.

Hidden temp onion's are created with --bind-addr=autotor:127.0.0.1:9051 you can verify by

`xxd -l 32 -ps -c 32 /var/run/tor/control.authcookie

nc 127.0.0.1 9051
AUTHENTICATE [here the string that xxd from authcookie returned]
getinfo onions/detached`

@gabridome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So to know address it is necessary to "AUTHENTICATE" now?

Also: there are a few things I think it is necessary to change about the doc:
In several parts of the document I have used tor or TOR. The name should be Tor (this probably includes the name of the file...).

Also the table I made regarding the various cases does not show up well with the new publishing procedure @cdecker has set up.

I'm available to work on it if you are not already doing so.

@Saibato
Copy link
Contributor

@Saibato Saibato commented on 02ddeed Apr 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure, if I can do anything more in this project in regards to Tor or privacy
Maybe I fork, please DM :-)

I prefer to work in the spirit of Hobbit from whom I steal most of my code :-)

@Saibato
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to push a patch in my repro under tag tor-autotor that list with getinfo on flag --show-hidden also unannounced addresses
And I also have to check what works and not in master.

My own LN forked long ago and is no longer compatible, but from there a more privacy orientated p-LN is possible to create.

I.e. the direct Pay without prior invoice I just implemented by tunnel over ping
But that is something that will never get any approve by regulators so it's just private useable

@gabridome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. that's my fingerprint in any case for further communications.
DC47A9B4CF4163736EBBE14EA48FBF051C43F817

@Saibato
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autism + paranoid = bitcoin + ln
🦄

@Saibato
Copy link
Contributor

@Saibato Saibato commented on 02ddeed Apr 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here a draft 25a2a84 for a docu change in regards to --addr=autotor

if you want to make a PR just cherry-pick what you find useful.
I always CC-0 and just want things to get done.
And if you do the PR it will be I am sure far better and more readable.

tag tor-autotor da5e582

@gabridome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Saibato,
When you write:"you ask the Tor service api and do a getinfo onions/detached to list your temp onions" that means: lightning-cli getinfo onions/detached? Is it a new option?

@Saibato
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange but fact the Tor service api has also a getinfo but you can ask it for special values, something that might be useful for LN also.

@gabridome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Found the documentation API. I will put a link if someone needs it.
It seems prohibitive to find your own .onion address in this set up but I guess this could serve well whoever wants to connect to a node and doesn't need to accept connections.

@gabridome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, if your purpose is to be able to connect to other nodes but not to be reachable by other nodes' connections, the way you do it is to set the socks5 proxy --proxy=127.0.0.1:9050.

I'm afraid there's not a practical use case for --bind-addr=autotor:127.0.0.1:9150 unless there is an easy way for the owner of the node to selectively disclose his .onion address and using the API or the SUPERVERBOSE log is prohibitive.

One easy way to selectively disclose your .onion address would be if it appeared in your lightning-cli getinfo but it wasn't announced on the network. in this way you could pass it off band to whoever you choose.

@Saibato
Copy link
Contributor

@Saibato Saibato commented on 02ddeed Apr 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think about that ..

[WIP] Show the Tor onion address 3b18cf0

Fully functional {WIP] to show the .onion address with flag --enable-getinfo-all=true ( default false )

  • add tests
  • add docu

Please sign in to comment.