-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues/406 latest cves #407
Conversation
@@ -73,7 +73,7 @@ | |||
"build": "tsc && vite build", | |||
"serve": "vite preview --outDir build", | |||
"test": "vitest", | |||
"test-pre-commit": "vitest --run", | |||
"test-pre-commit": "cross-env NODE_ENV=test vitest --run", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the other changes to packages in here were directly related to CVEs, this change, along with the adding of the cross-env
package, was a result of a side effect after patch upgrading vite.
In the pre-commit hook, tests were running in production env, and resulting in this error:
act(...) is not supported in production builds of React
Setting NODE_ENV=test
before running ensure it runs in test environment, and doesn't have an issue with act(...)
. Using the cross-env
package for that is to make setting the variable as platform agnostic as possible.
Thanks to this github issue discussion: Github issue discussion
This all looks good, but under the green check marks, we do have a pipeline warning:
Maybe that is just another ticket for the backlog. |
Closes #406 |
New issue to address the pipeline node version warning here: #408 |
Related Issue(s):
Proposed Changes:
PR Checklist: