Make zoom level variable optional #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philvarner
reviewed
Feb 20, 2023
| @@ -27,7 +27,7 @@ const BottomContent = () => { | |||
|
|
|||
| const ANALYZE_LINK = process.env.REACT_APP_ANALYZE_BTN_URL | |||
| const SHOW_PUBLISH_BTN = process.env.REACT_APP_SHOW_PUBLISH_BTN | |||
| const MIN_ZOOM = process.env.REACT_APP_MIN_ZOOM_LEVEL | |||
| const MIN_ZOOM = process.env.REACT_APP_MIN_ZOOM_LEVEL || 7 | |||
There was a problem hiding this comment.
Since the default value is used in two different files, it should be re-used from a common constant. You could put the definition of const MIN_ZOOM = process.env.REACT_APP_MIN_ZOOM_LEVEL || 7 in a new filesrc/components/defaults.js and export it, and then import it as a MIN_ZOOM.
philvarner
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
PR Checklist: