Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ba/feature/add config setting for e84 logo #211

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

bradleyandrick
Copy link
Contributor

Related Issue(s):

  • NA

Proposed Changes:

  1. Add config var for SHOW_BRAND_LOGO
  2. Update example config to include SHOW_BRAND_LOGO
  3. Add new var info to readme
  4. Update mock for tests
  5. Fix prettier issue with new version (and add back in check for html)

To test

  • edit local config.json file to include "SHOW_BRAND_LOGO": true
  • run app
  • confirm logo renders in top right of UI
  • stop app
  • change local config.json file to be "SHOW_BRAND_LOGO": false
  • run app
  • confirm logo does not render in top right of UI
  • stop app
  • change local config.json file to include a URL for DASHBOARD_BTN_URL like "DASHBOARD_BTN_URL": "https://www.google.com"
  • run app
  • confirm dashboard button renders correctly with and without brand logo showing

unit tests pass 🍏

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@bradleyandrick bradleyandrick merged commit b5cec51 into main Jul 25, 2023
@bradleyandrick bradleyandrick deleted the ba/feature/add-config-setting-for-e84Logo branch August 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants