Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadmore组件的translate计算的Bug #1372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SugarTiger
Copy link

@SugarTiger SugarTiger commented May 25, 2018

loadmore组件 translate的计算,应该是手指移动的距离distance 先和 scrollTop进行运算后的值再和手指移动与组件移动距离的比值distanceIndex相除;而不是distance 先除以distanceIndex,再和scrollTop作运算,此做法会导致,当loadmore组件已经下拉或者上拉了一段距离后,再通过手指直接上拉或者下拉到达顶部或者底部的时候,translate并没有变化 ,需要继续拉动一段距离translate才会变化.
tab-container组件的mouse事件处理,建议不要直接在组件上绑定mousemove和mouseup,因为可能在滑动的时候,松开鼠标的时候,鼠标已经不再组件上方了,然后鼠标移动回组件里面的时候,组件会跟着鼠标滑动。所以建议把mousemove和mouseup绑定到document.documentElement对象上,并且是在组件的mousedown数据触发时才绑定,mouseup事件触发时或者组件destroyed钩子触发的时候就解除绑定

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant