Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen readers optimizations #423

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Screen readers optimizations #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions templates/footer.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<a href="{{ path('jobs') }}">
Nous recrutons
{% if count %}
<span class="bullet">{{ count }}</span>
<span class="bullet" aria-hidden="true">{{ count }}</span>
{% endif %}
</a>
</li>
Expand All @@ -37,19 +37,19 @@
<ul>
<li>
<a href="{{ site.social.github }}" target="_blank">
<i class="icon icon--github"></i>
<i class="icon icon--github" aria-hidden="true"></i>
Github
</a>
</li>
<li>
<a href="{{ site.social.twitter }}" target="_blank">
<i class="icon icon--twitter"></i>
<i class="icon icon--twitter" aria-hidden="true"></i>
Twitter
</a>
</li>
<li>
<a href="{{ site.social.instagram }}" target="_blank">
<i class="icon icon--instagram"></i>
<i class="icon icon--instagram" aria-hidden="true"></i>
Instagram
</a>
</li>
Expand Down
4 changes: 2 additions & 2 deletions templates/partials/brick-contact.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<div class="brick-contact" data-aos="zoom-in-up" data-aos-delay="150">
<h3 class="title">Nous contacter</h3>
<address>
<i class="icon icon--phone"></i>
<i class="icon icon--phone" aria-hidden="true"></i>
<a href="tel://{{ site.contact.phone }}">{{ site.contact.phone }}</a>
</address>
<address>
<i class="icon icon--write"></i>
<i class="icon icon--write" aria-hidden="true"></i>
<a href="mailto://{{ site.contact.email }}">{{ site.contact.email }}</a>
</address>
</div>
2 changes: 1 addition & 1 deletion templates/partials/brick-visit.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="brick-visit" data-aos="zoom-in-up" data-aos-delay="150">
<h3 class="title">Venir nous voir</h3>
<address class="address">
<i class="icon icon--location"></i>
<i class="icon icon--location" aria-hidden="true"></i>
<a class="address__content" href="{{ site.contact.address.google_maps }}" target="_blank">
<span>34 rue Jean Broquin</span>
<span>69006 Lyon</span>
Expand Down
2 changes: 1 addition & 1 deletion templates/partials/svg-arrow.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<svg class="icon" xmlns="http://www.w3.org/2000/svg" x="0" y="0" viewBox="0 0 40 20">
<svg class="icon" xmlns="http://www.w3.org/2000/svg" x="0" y="0" viewBox="0 0 40 20" aria-hidden="true">
<path class="tip" d="M21,2.7 28.2,10.3 21,17.4"/>
<path class="base" d="M28.2,10.3c-0.1,0-18.3,0-27.8,0"/>
</svg>
14 changes: 7 additions & 7 deletions templates/site/home.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
<div class="section-home__links" data-aos="fade-in" data-aos-delay="200">
<a class="animated-block">
<div class="animated-block__icon">
<svg xmlns="http://www.w3.org/2000/svg" x="0" y="0" width="45px" height="30" viewBox="0 0 45 30" class="browser">
<svg xmlns="http://www.w3.org/2000/svg" x="0" y="0" width="45px" height="30" viewBox="0 0 45 30" class="browser" aria-hidden="true">
<rect x="3.3" y="6.8" width="37.8" height="1"/>
<circle cx="7.1" cy="3.5" r="0.9"/>
<circle cx="4.3" cy="3.5" r="0.9"/>
Expand Down Expand Up @@ -212,14 +212,14 @@
<div class="animated-block__content">
<p class="title">
Contribution
<i class="icon"></i>
<i class="icon" aria-hidden="true"></i>
</p>
<p>Core team Symfony</p>
</div>
</a>
<a href="https://youtu.be/YPLlzte7tgs?list=PLkJgdYh31EJGz3SD2rY4GUaZfck10OQRl" target="_blank" class="animated-block" data-aos="fade-in" data-aos-delay="400">
<div class="animated-block__icon">
<svg xmlns="http://www.w3.org/2000/svg" x="0" y="0" width="45" height="30" viewBox="0 0 45 30" class="bulb">
<svg xmlns="http://www.w3.org/2000/svg" x="0" y="0" width="45" height="30" viewBox="0 0 45 30" class="bulb" aria-hidden="true">
<path d="M20.4,12.4c0-4.4-3.6-8-8-8 c-4.4,0-8,3.6-8,8c0,2.7,2.8,5.8,3.3,7.3s0,4.8,0,4.8c0,1,0.8,1.8,1.8,1.8h6.2c1,0,1.8-0.8,1.8-1.8c0,0-0.6-3.3,0-4.8 C18,18.2,20.4,14.9,20.4,12.4z"/>
<line x1="7.6" y1="21.9" x2="13.8" y2="21.9"/>
<path d="M12.6,29.3c1.7,0,3.1-1.4,3.1-3.1H9.5C9.5,28,10.9,29.3,12.6,29.3z
Expand All @@ -239,14 +239,14 @@
<div class="animated-block__content">
<p class="title">
Conférences
<i class="icon icon--arrow"></i>
<i class="icon icon--arrow" aria-hidden="true"></i>
</p>
<p>Elao Summer Talk #2</p>
</div>
</a>
<a href="{{ path('blog_article', { article: lastArticle.slug }) }}" class="animated-block" data-aos="fade-in" data-aos-delay="600">
<div class="animated-block__icon">
<svg xmlns="http://www.w3.org/2000/svg" x="0" y="0" width="45" height="30" viewBox="0 0 45 30" class="pen">
<svg xmlns="http://www.w3.org/2000/svg" x="0" y="0" width="45" height="30" viewBox="0 0 45 30" class="pen" aria-hidden="true">
<rect x="0.6" y="28.4" height="1"/>
<path d="M19.4,4.1l0.7,0.7L4.2,20.7l2.4,2.4L22.5,7.2L23.2,8L7.3,23.9l2.4,2.4
l15.9-15.9l0.7,0.7L10.1,27.4c0,0-0.1,0.1-0.2,0.1c0,0,0,0,0,0s0,0,0,0l-8.2,1.9c-0.2,0-0.4,0-0.5-0.1S1,29,1,28.8l1.9-8.2 c0,0,0,0,0,0c0,0,0,0,0,0c0-0.1,0.1-0.1,0.1-0.2L19.4,4.1z M2.7,26.4l-0.4,1.9l1.9-0.4L2.7,26.4z M3.7,21.8l-0.8,3.4c0,0,0,0,0,0 l2.3,2.3c0,0,0,0,0,0l3.4-0.8L3.7,21.8z M23.7,0.7c0.6,0,1.2,0.2,1.7,0.7L29,5c0.5,0.5,0.7,1.1,0.7,1.7c0,0.6-0.2,1.2-0.7,1.7 l-1.3,1.3c-0.2,0.2-0.5,0.2-0.7,0l-6.3-6.3c-0.1-0.1-0.2-0.2-0.2-0.4c0-0.1,0.1-0.3,0.2-0.4L22,1.4C22.5,0.9,23.1,0.7,23.7,0.7z M23.7,1.8c-0.3,0-0.7,0.1-1,0.4l-0.9,0.9l5.6,5.6l0.9-0.9c0.3-0.3,0.4-0.6,0.4-1c0-0.3-0.1-0.7-0.4-1l-3.6-3.6 C24.4,1.9,24.1,1.8,23.7,1.8L23.7,1.8z"/>
Expand All @@ -255,7 +255,7 @@
<div class="animated-block__content">
<p class="title">
Article de blog
<i class="icon icon--arrow"></i>
<i class="icon icon--arrow" aria-hidden="true"></i>
</p>
<p>{{ lastArticle.title }}</p>
</div>
Expand All @@ -277,7 +277,7 @@
<h3 class="title">Rejoindre la tribu</h3>
{% set count = content_list('App\\Model\\Job', null, { active: true })|length %}
{% if count > 0 %}
<span class="subtitle">{{ 'job_offers'|trans({ count: count }) }}</span>
<span class="subtitle" aria-hidden="true">{{ 'job_offers'|trans({ count: count }) }}</span>
{% endif %}
</a>
</aside>
Expand Down