Allow usage of FCQN instead of aliases in Faker provider #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Apr 9, 2018
| @@ -40,6 +45,9 @@ public function testRandomEnumMethodShouldReturnExpectedEnums() | |||
| $simple = $enumProvider->randomEnum('Simple'); | |||
| $this->assertInstanceOf(SimpleEnum::class, $simple); | |||
|
|
|||
| $gender = $enumProvider->enum('Elao\Enum\Tests\Fixtures\Enum\Gender::MALE'); | |||
There was a problem hiding this comment.
It's supposed to test randomEnum here 😄 (fixed in a15590d)
|
Thank you @ostrolucky. |
ogizanagi
added a commit
that referenced
this pull request
Apr 9, 2018
…(ostrolucky) This PR was merged into the 1.x-dev branch. Discussion ---------- Allow usage of FCQN instead of aliases in Faker provider This allows avoiding defining alias map if I want to use this provider Commits ------- 98178a5 Allow usage of FCQN instead of aliases in Faker provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows avoiding defining alias map if I want to use this provider