Add ScalarToEnumTransformer #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Apr 8, 2018
| * @expectedException \Symfony\Component\Form\Exception\InvalidArgumentException | ||
| * @expectedExceptionMessage "stdClass" is not an instance of "Elao\Enum\EnumInterface" | ||
| */ | ||
| public function testThrowsExceptionIfNotFLaggedEnumInstance() |
There was a problem hiding this comment.
- testThrowsExceptionIfNotFLaggedEnumInstance
+ testThrowsExceptionIfNotEnumInstance
|
Of course. Just didn't want to spend more time on figuring out how to integrate this there. It can be used standalone for now. We can integrate it later :) |
ogizanagi
approved these changes
Apr 9, 2018
|
Thanks @ostrolucky. |
ogizanagi
added a commit
that referenced
this pull request
Apr 9, 2018
This PR was merged into the 1.x-dev branch. Discussion ---------- Add ScalarToEnumTransformer I found EnumType very limiting, because it enforces either Enum instances inside choices, or scalar value as output. This is inconvenient, because it's common to have scalar key-value pairs stored as an array in class constant. Storing there objects is not possible. So, this transformer is meant to be used in conjunction with normal ChoiceType and scalar choices. Commits ------- 9683e83 Add ScalarToEnumTransformer
ogizanagi
added a commit
that referenced
this pull request
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found EnumType very limiting, because it enforces either Enum instances inside choices, or scalar value as output.
This is inconvenient, because it's common to have scalar key-value pairs stored as an array in class constant. Storing there objects is not possible.
So, this transformer is meant to be used in conjunction with normal ChoiceType and scalar choices.