Change AutoDiscoveredValuesTrait to use constant values as keys #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be solved by #49 with no potential BC issue, in respect of the initial However, I'm asking you: would you prefer default labels being the value itself, or a human representation of the constant name as done in default implementation of the FlaggedEnum? |
3 tasks
|
Thank you for welcoming similar idea. Let's continue in #49 |
ogizanagi
added a commit
that referenced
this pull request
Apr 13, 2018
This PR was merged into the 1.x-dev branch. Discussion ---------- Add ChoiceEnumTrait & SimpleChoiceEnum Fixes #46 ```php final class DummyEnum extends ReadableEnum { use ChoiceEnumTrait; const FOO = 'foo'; const BAR = 'bar'; const BAZ = 'baz'; protected static function choices(): array { return [ static::FOO => 'Foo label', static::BAR => 'Bar label', static::BAZ => 'Baz label', ]; } } ``` or with autodiscovery & enum values as default labels: ```php final class DummyEnum extends SimpleChoiceEnum { const FOO = 'foo'; const BAR = 'bar'; const BAZ = 'baz'; } ``` ### TODO - [x] Update docs - [x] Change default implem for readables? (see #47 (comment)) - [ ] ~~Reverse `choices()` returned map? (labels as keys instead of values as in #46 descr). It requires extra work, deduplication and can lead to confusion, so I personally don't see the benefit.~~ No Commits ------- 1d816bd Add ChoiceEnumTrait & SimpleChoiceEnum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, can I have this change? It aids with #46
For some enums, it's ok to have label same as value. In those cases, this allows to not having to define neither values() and neither readables(). Shouldn't pose too big risk of BC break.