Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of the translatable interface. #224

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Implementation of the translatable interface. #224

merged 1 commit into from
Jul 5, 2023

Conversation

laurentmuller
Copy link
Contributor

This is the PR for the feature #221.

ogizanagi
ogizanagi approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Could you please add a section describing this and the usage in the README.md file ?

@laurentmuller
Copy link
Contributor Author

Thank You. I will update the README.md file.

@ogizanagi
Copy link
Member

Thank you @laurentmuller.

@ogizanagi ogizanagi merged commit 8b09a3a into Elao:2.x Jul 5, 2023
@laurentmuller
Copy link
Contributor Author

You'r welcome.

@laurentmuller
Copy link
Contributor Author

Any release ?

@IonBazan
Copy link
Contributor

IonBazan commented Jul 6, 2023

I think we should add some tests for this 🤔

@norkunas
Copy link

norkunas commented Aug 2, 2023 •
edited
Loading

Since symfony/symfony#50931 if TranslatableInterface would be used instead of TranslatableEnumInterface there would be no need to have a Elao\Enum\Bridge\Symfony\Form\Type\EnumType and directly use one from Symfony.

edit: missed that TranslatableEnumInterface extends TranslatableInterface. Just don't see any point from that interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurentmuller @ogizanagi @IonBazan @norkunas