allow int enum to be normalized as int #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximecolin
force-pushed
the
maximecolin-patch-1
branch
from
3cda121 to
f426f9e
Compare
benji07
reviewed
Feb 20, 2023
| @@ -27,8 +27,10 @@ class EnumNormalizer implements NormalizerInterface, DenormalizerInterface | |||
| * {@inheritdoc} | |||
| * | |||
| * @param EnumInterface $object | |||
| * | |||
| * @return string|int | |||
There was a problem hiding this comment.
Suggested change
| * @return string|int | |
| * @return mixed |
Peut être voir si on peux mettre des générics phpstan ici ( en mettant le param EnumInterface et return T)
There was a problem hiding this comment.
I don't think it'll works here, since we have no way to indicate the template type.
It works when extending a base class defining a template. I'm not sure it's valid as is.
At least it misses @template T of int|string ?
maximecolin
force-pushed
the
maximecolin-patch-1
branch
from
f426f9e to
1615515
Compare
|
Thanks Maxime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.