Fix return type for Enum::instances() #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Elao team!
We are switching from
myclabs/php-enum
to your package because of your great integration with symfony (mostly DBAL types and serializer).It seems that the return type of the
Enum::instances()
method does not suit well for our dear friend phpstan :DI suppose this is not done on purpose since an override of the return type has been done for the
::get()
method:EnumInterface::get(): EnumInterface
->Enum::get(): static
So I suggest to do the same with the
Enum::instances()
method.Cheers, and gros poutous