Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type for Enum::instances() #127

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

devster
Copy link
Contributor

@devster devster commented Apr 1, 2021

Hi Elao team!

We are switching from myclabs/php-enum to your package because of your great integration with symfony (mostly DBAL types and serializer).

It seems that the return type of the Enum::instances() method does not suit well for our dear friend phpstan :D

I suppose this is not done on purpose since an override of the return type has been done for the ::get() method:
EnumInterface::get(): EnumInterface -> Enum::get(): static

So I suggest to do the same with the Enum::instances() method.

Cheers, and gros poutous

@chalasr
Copy link
Contributor

chalasr commented Apr 1, 2021

👍 build failures all seem unrelated

@ogizanagi
Copy link
Member

Thanks and safe poutous ;)

@ogizanagi ogizanagi merged commit accf9f5 into Elao:master Apr 1, 2021
@devster
Copy link
Contributor Author

devster commented Apr 1, 2021

Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants