Skip to content

Commit

Permalink
Merge pull request #2 from JMS55/24
Browse files Browse the repository at this point in the history
Don't support diagnostic filters for now
  • Loading branch information
Elabajaba authored Jan 25, 2025
2 parents 7555773 + 537e291 commit 9f29ae3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/compose/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,7 @@ impl Composer {
expressions: Default::default(),
named_expressions: Default::default(),
body: Default::default(),
diagnostic_filter_leaf: todo!(),
diagnostic_filter_leaf: None,
};

// record owned function
Expand Down Expand Up @@ -1083,7 +1083,7 @@ impl Composer {
expressions: Default::default(),
named_expressions: Default::default(),
body: Default::default(),
diagnostic_filter_leaf: todo!(),
diagnostic_filter_leaf: None,
};

owned_functions.insert(ep.function.name.clone().unwrap(), (None, header_function));
Expand Down
1 change: 1 addition & 0 deletions src/compose/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1264,6 +1264,7 @@ mod test {
}

#[test]
#[should_panic] // Diagnostic filters not yet supported
fn test_diagnostic_filters() {
let mut composer = Composer::default();

Expand Down
6 changes: 3 additions & 3 deletions src/derive.rs
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ impl<'a> DerivedModule<'a> {
expressions: Rc::try_unwrap(expressions).unwrap().into_inner(),
named_expressions,
body,
diagnostic_filter_leaf: todo!(),
diagnostic_filter_leaf: None,
}
}

Expand Down Expand Up @@ -867,8 +867,8 @@ impl From<DerivedModule<'_>> for naga::Module {
special_types: Default::default(),
entry_points: Default::default(),
overrides: derived.pipeline_overrides,
diagnostic_filters: todo!(),
diagnostic_filter_leaf: todo!(),
diagnostic_filters: Default::default(),
diagnostic_filter_leaf: None,
}
}
}

0 comments on commit 9f29ae3

Please sign in to comment.