Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Differentiate plugin log from Vite log #19

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[1.x] Differentiate plugin log from Vite log #19

merged 1 commit into from
Jul 8, 2024

Conversation

timacdonald
Copy link
Contributor

Hey @ElMassimo! Got a small proposal here for your consideration.

Currently, when the Full Reload plugin performs a reload it logs the following...

Screen Shot 2023-06-14 at 10 05 15 am

This is great.

If I disable the Full Reload plugin and have a dependency loop, which is very common when using something like Tailwind CSS with template files, Vite will output the following when a dependency in said loop is updated...

Screen Shot 2023-06-14 at 10 08 02 am

When seen in combination it makes it harder debug where the issue came from. Was this reload triggered by Full Reload or by Vite? I would like to propose that the console output for this plugin differentiate itself from the logging that Vite itself does.

This is really just a debugging improvement to determine where the issue actually came from.

Screen Shot 2023-06-14 at 10 13 49 am

Thanks again for this fantastic plugin.

@ElMassimo
Copy link
Owner

Hi @timacdonald, sorry for the delay on this one.

I think this is a nice improvement, would be happy to merge and release.

@timacdonald timacdonald restored the patch-1 branch July 8, 2024 22:43
@timacdonald timacdonald reopened this Jul 8, 2024
@timacdonald
Copy link
Contributor Author

@ElMassimo, no worries! I was just doing some tidying up on my GitHub account.

Reopened it for ya.

@ElMassimo ElMassimo merged commit 943016d into ElMassimo:main Jul 8, 2024
@timacdonald timacdonald deleted the patch-1 branch July 9, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants