typo in packaging configuration fixed, now builds packages correctly #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 🙂 |
|
This breaks output filename at least for DEB files |
Yes, I noticed that the DEB files are not named properly, but cpack wasn't working AT ALL before this. So I chose to not deep-dive into the reason why the filename was not right. If you like I can fix the package name too ? It's beyond the scope of just fixing the typo. |
|
If the only issue was "generator not specified" you can provide generator on command line, like this |
no, your guess was not correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like a few letters were jumbled for some reason. This broke cpack.
Works now!