Skip to content

Commit

Permalink
YQ-2899 fix url escaping (ydb-platform#3439)
Browse files Browse the repository at this point in the history
  • Loading branch information
GrigoriyPA authored and EgorkaZ committed Apr 8, 2024
1 parent add75cc commit dec9e00
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ydb/library/yql/providers/s3/actors/yql_s3_read_actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1829,7 +1829,7 @@ class TS3ReadCoroImpl : public TActorCoroImpl {
if (it != RangeCache.end()) {
return it->second;
}
RetryStuff->Gateway->Download(Url + Path, RetryStuff->Headers,
RetryStuff->Gateway->Download(RetryStuff->Url, RetryStuff->Headers,
range.Offset,
range.Length,
std::bind(&OnResult, GetActorSystem(), SelfActorId, range, ++RangeCookie, std::placeholders::_1),
Expand Down
2 changes: 1 addition & 1 deletion ydb/tests/fq/s3/test_insert.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def create_bucket_and_upload_file(self, filename, s3, kikimr):

@yq_all
@pytest.mark.parametrize("dataset_name", ["dataset", "dataにちは% set"])
@pytest.mark.parametrize("format", ["json_list", "json_each_row", "csv_with_names"])
@pytest.mark.parametrize("format", ["json_list", "json_each_row", "csv_with_names", "parquet"])
@pytest.mark.parametrize("client", [{"folder_id": "my_folder"}], indirect=True)
def test_insert(self, kikimr, s3, client, format, dataset_name):
resource = boto3.resource(
Expand Down

0 comments on commit dec9e00

Please sign in to comment.