Add number round #3533
Merged
Add number round #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fb6a244 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I'm trying to remove lodash from my project in favor of native node features and effect features and this one was missing. |
github-actions
bot
force-pushed
the
next-minor
branch
2 times, most recently
from
9c4ba21
to
5eb5ad7
Compare
tim-smart
requested changes
Sep 4, 2024
packages/effect/src/Number.ts
Outdated
| * import { round } from "effect/Number" | ||
| * | ||
| * assert.deepStrictEqual(round(5,1234, 2), 5.12) | ||
| * assert.deepStrictEqual(nextPow2(17), 32) |
There was a problem hiding this comment.
This can be removed (nextPow2).
There was a problem hiding this comment.
Sorry for that. I started to write the doc and stopped to write the tests first and forgot to come back to it.
There was also a mistake on the first line, by the way
github-actions
bot
force-pushed
the
next-minor
branch
3 times, most recently
from
36a5be1
to
00583f3
Compare
github-actions
bot
force-pushed
the
next-minor
branch
from
00583f3
to
89c3411
Compare
tim-smart
approved these changes
Sep 4, 2024
Merged
tim-smart
pushed a commit
that referenced
this pull request
Sep 7, 2024
Closed
tim-smart
pushed a commit
that referenced
this pull request
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Adds
Number.roundmethod to which you can pass a precision.* assert.deepStrictEqual(round(5,1234, 2), 5.12)Related