Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FiberRefs perf work #3518

Merged
merged 1 commit into from
Sep 3, 2024
Merged

FiberRefs perf work #3518

merged 1 commit into from
Sep 3, 2024

Conversation

mikearnaldi
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: ddbd175

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@effect/opentelemetry Major
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor August 30, 2024 11:03
@mikearnaldi
Copy link
Member Author

@tim-smart from preliminary testing by @schickling this seems to have a large (positive) impact, not sure which change specifically my guess is more aggressive caching

@tim-smart
Copy link
Member

Yes I think the caching would have the largest impact.

Will measure the changes separately later to see how they affect performance.

@mikearnaldi mikearnaldi marked this pull request as ready for review September 2, 2024 09:02
@mikearnaldi
Copy link
Member Author

waiting for green light from @schickling to merge this

@schickling
Copy link

image

@mikearnaldi mikearnaldi merged commit c654e54 into next-minor Sep 3, 2024
11 checks passed
@mikearnaldi mikearnaldi deleted the perf/hardening-refs branch September 3, 2024 09:34
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
github-actions bot pushed a commit that referenced this pull request Sep 6, 2024
github-actions bot pushed a commit that referenced this pull request Sep 6, 2024
github-actions bot pushed a commit that referenced this pull request Sep 6, 2024
github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
tim-smart pushed a commit that referenced this pull request Sep 7, 2024
github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
github-actions bot pushed a commit that referenced this pull request Sep 7, 2024
@tim-smart tim-smart mentioned this pull request Sep 9, 2024
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
github-actions bot pushed a commit that referenced this pull request Sep 10, 2024
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 15, 2024
tim-smart pushed a commit that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants