Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Random.choice #3314

Merged
merged 5 commits into from
Jul 26, 2024
Merged

add Random.choice #3314

merged 5 commits into from
Jul 26, 2024

Conversation

sukovanej
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2ec742f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot changed the base branch from main to next-minor July 21, 2024 18:42
datner
datner reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@datner datner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature, I like

packages/effect/test/Random.test.ts Outdated
Comment on lines 29 to 38
it.live("choice", () =>
Effect.gen(function*() {
expect(yield* Random.choice([1])).toEqual(1)
expect(yield* Random.choice([1, 2, 3])).oneOf([1, 2, 3])
}))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. whats it.live?
  2. maybe seed Random? and see that it
    a. does not yield the same thing every time
    b. is deterministic when seeded
    Or even use fast-check so repeatN won't be required like it's used in other tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. it.effect provides a TestEnv by default, it.live opts-out
  2. fast-check is probably a good way but even a repeated test would be fine

@github-actions github-actions bot force-pushed the next-minor branch 2 times, most recently from 32ed129 to 716d157 Compare July 23, 2024 07:23
KhraksMamtsov
KhraksMamtsov reviewed Jul 23, 2024
View reviewed changes
packages/effect/src/internal/defaultServices.ts Outdated Show resolved Hide resolved
packages/effect/src/Random.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot force-pushed the next-minor branch 6 times, most recently from a4c3408 to 95019bb Compare July 23, 2024 15:32
@github-actions github-actions bot force-pushed the next-minor branch 9 times, most recently from 62144fc to 0b36055 Compare July 25, 2024 11:13
tim-smart
tim-smart reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@tim-smart tim-smart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8y94vp

packages/effect/src/Random.ts Outdated Show resolved Hide resolved
packages/effect/src/Random.ts Outdated Show resolved Hide resolved
@tim-smart tim-smart merged commit 319f038 into Effect-TS:next-minor Jul 26, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Jul 26, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
@sukovanej @tim-smart @gcanti
add Random.choice (#3314)
6a79f6f 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
@sukovanej @tim-smart @gcanti
add Random.choice (#3314)
04ef780 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
@sukovanej @tim-smart @gcanti
add Random.choice (#3314)
2f9b398 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
@sukovanej @tim-smart @IMax153
add Random.choice (#3314)
c174600 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 27, 2024
@sukovanej @tim-smart @gcanti
add Random.choice (#3314)
7854b34 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
ca11e3b 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
e0d00a9 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
1032b8e 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@sukovanej @tim-smart @gcanti
add Random.choice (#3314)
10b5e79 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@sukovanej @tim-smart @fubhy
add Random.choice (#3314)
96d84bd 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@sukovanej @tim-smart @gcanti
add Random.choice (#3314)
1ad65cf 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@sukovanej @tim-smart @gcanti
add Random.choice (#3314)
bc28a9c 
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Jul 29, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
cc76cf2 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
b4c850f 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
df8f0d5 
Co-authored-by: Tim <hello@timsmart.co>
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
0d3fa6a 
Co-authored-by: Tim <hello@timsmart.co>
tim-smart added a commit that referenced this pull request Jul 30, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
fb08fcc 
Co-authored-by: Tim <hello@timsmart.co>
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
Merged
tim-smart added a commit that referenced this pull request Jul 30, 2024
@sukovanej @tim-smart
add Random.choice (#3314)
2d09078 
Co-authored-by: Tim <hello@timsmart.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-smart tim-smart tim-smart left review comments

@dilame dilame dilame left review comments

@KhraksMamtsov KhraksMamtsov KhraksMamtsov left review comments

@datner datner datner left review comments

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees
No one assigned
Labels
next-minor
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sukovanej @tim-smart @dilame @KhraksMamtsov @datner @mikearnaldi