Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Stream.asyncPush api #3277

Merged
merged 12 commits into from
Jul 19, 2024
Merged

add Stream.asyncPush api #3277

merged 12 commits into from
Jul 19, 2024

Conversation

tim-smart
Copy link
Member

@tim-smart tim-smart commented Jul 16, 2024

No description provided.

Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: c4f1c3e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/schema Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikearnaldi
Copy link
Member

Same as in the other PR, dropping elements by default is not a good choice

@mikearnaldi
Copy link
Member

Options could be { strategy: "unbounded" } by default and potentially accept { strategy: "dropping" / "sliding", size: 100 }

The nice aspect about this is that assuming we don't support backpressure we can guarantee sync push, which would be faster than the plain async way

@tim-smart
Copy link
Member Author

/rebase

github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
github-actions bot pushed a commit that referenced this pull request Jul 25, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
github-actions bot pushed a commit that referenced this pull request Jul 27, 2024
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
github-actions bot pushed a commit that referenced this pull request Jul 28, 2024
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
tim-smart added a commit that referenced this pull request Jul 29, 2024
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
tim-smart added a commit that referenced this pull request Jul 30, 2024
@github-actions github-actions bot mentioned this pull request Jul 30, 2024
tim-smart added a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants