Improving Predicate Usability of Schema.is
#2756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this update, the
Schema.is(mySchema)
function couldn't be easily used as a predicate or refinement in common array methods likefilter
orfind
. This was because the function's signature was:Meanwhile, the function expected by methods like
filter
has the following signature:To make
Schema.is
compatible with these array methods, we've adjusted the function's signature to acceptnumber
as a possible value for the second parameter, in which case it is ignored:Here's a practical example comparing the behavior before and after the change:
Before:
Now:
Note that the result has been correctly narrowed to
string[]
.