Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sql.update default arguments #2685

Merged
merged 3 commits into from
May 2, 2024

Conversation

giacomoran
Copy link
Contributor

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

In @effect/sql, Constructor["update"] implementation is missing default value for omit?: ReadonlyArray<keyof A> argument.

@giacomoran giacomoran requested a review from tim-smart as a code owner May 2, 2024 12:52
Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 0596f26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@effect/sql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart tim-smart merged commit d3cf2d8 into Effect-TS:main May 2, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request May 2, 2024
@giacomoran giacomoran deleted the sql/fix-sql-update branch May 3, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants