skip running effects in FiberHandle/Map if not required

Effect-TS · Apr 16, 2024 · 3143c02 · 3143c02
1 parent 1713d63
commit 3143c02
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/.changeset/dirty-bees-mix.md b/.changeset/dirty-bees-mix.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+skip running effects in FiberHandle/Map if not required
diff --git a/packages/effect/src/FiberHandle.ts b/packages/effect/src/FiberHandle.ts
@@ -307,6 +307,8 @@ export const run: {
     return Effect.suspend(() => {
       if (self.state._tag === "Closed") {
         return Effect.interrupt
+      } else if (self.state.fiber !== undefined && options?.onlyIfMissing === true) {
+        return set(self, Effect.runFork(Effect.never), options)
       }
       return Effect.uninterruptibleMask((restore) =>
         Effect.tap(
@@ -321,6 +323,8 @@ export const run: {
     Effect.suspend(() => {
       if (self.state._tag === "Closed") {
         return Effect.interrupt
+      } else if (self.state.fiber !== undefined && options?.onlyIfMissing === true) {
+        return set(self, Effect.runFork(Effect.never), options)
       }
       return Effect.uninterruptibleMask((restore) =>
         Effect.tap(

diff --git a/packages/effect/src/FiberMap.ts b/packages/effect/src/FiberMap.ts
@@ -410,6 +410,8 @@ export const run: {
     return Effect.suspend(() => {
       if (self.state._tag === "Closed") {
         return Effect.interrupt
+      } else if (unsafeHas(self, key) && options?.onlyIfMissing === true) {
+        return set(self, key, Effect.runFork(Effect.never), options)
       }
       return Effect.uninterruptibleMask((restore) =>
         Effect.tap(
@@ -426,6 +428,8 @@ export const run: {
     Effect.suspend(() => {
       if (self.state._tag === "Closed") {
         return Effect.interrupt
+      } else if (unsafeHas(self, key) && options?.onlyIfMissing === true) {
+        return set(self, key, Effect.runFork(Effect.never), options)
       }
       return Effect.uninterruptibleMask((restore) =>
         Effect.tap(