ensure Stream.toReadableStream pulls always result in a enqueue (#3444)

Effect-TS · Aug 12, 2024 · 04adcac · 04adcac
1 parent 332b0c6
commit 04adcac
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/soft-cows-beam.md b/.changeset/soft-cows-beam.md
@@ -0,0 +1,5 @@
+---
+"effect": patch
+---
+
+ensure Stream.toReadableStream pulls always result in a enqueue
diff --git a/packages/effect/src/internal/stream.ts b/packages/effect/src/internal/stream.ts
@@ -6895,10 +6895,14 @@ export const toReadableStreamRuntime = dual<
     return new ReadableStream<A>({
       start(controller) {
         scope = runSync(Scope.make())
-        pull = pipe(
+        const pullChunk: Effect.Effect<Chunk.Chunk<A>, Option.Option<E>, R> = pipe(
           toPull(self),
           Scope.extend(scope),
           runSync,
+          Effect.flatMap((chunk) => Chunk.isEmpty(chunk) ? pullChunk : Effect.succeed(chunk))
+        )
+        pull = pipe(
+          pullChunk,
           Effect.tap((chunk) =>
             Effect.sync(() => {
               Chunk.map(chunk, (a) => {