add regression test for works, closes #169

Edirom · Jul 10, 2018 · 3b0b085 · 3b0b085
1 parent 2fd2998
commit 3b0b085
Show file tree

Hide file tree

Showing 8 changed files with 2,707 additions and 7 deletions.
diff --git a/build.xml b/build.xml
@@ -40,6 +40,7 @@
 
     <target name="test">
         <description>Run the regression test, i.e. diffing HTML pages against expected results</description>
+        <regressiontest doctype="works"/>
         <regressiontest doctype="letters"/>
         <regressiontest doctype="persons"/>
         <regressiontest doctype="orgs"/>

diff --git a/modules/query.xqm b/modules/query.xqm
@@ -44,12 +44,10 @@ declare function query:title($key as xs:string) as xs:string {
 :)
 declare function query:get-authorID($doc as document-node()?) as xs:string {
     let $author-element := query:get-author-element($doc)[1]
+    let $id := $author-element/@key | $author-element/@dbkey
     return
-        if(exists($doc)) then 
-            if(config:is-diary($doc/tei:ab/@xml:id)) then 'A002068' (: Diverse Sonderbehandlungen fürs Tagebuch :)
-            else if($author-element/@key) then $author-element/@key/string()
-            else if($author-element/@dbkey) then $author-element/@dbkey/string()
-            else config:get-option('anonymusID')
+        if(exists($doc) and $id) then string($id)
+        else if(exists($doc)) then config:get-option('anonymusID')
         else ''
 };
 
@@ -69,9 +67,9 @@ declare function query:get-authorName($doc as document-node()?) as xs:string {
 };
 
 declare function query:get-author-element($doc as document-node()?) as element()* {
-    if(config:is-diary($doc/tei:ab/@xml:id)) then <tei:author key="A002068">Weber, Carl Maria von</tei:author>
+    if(config:is-diary($doc/tei:ab/@xml:id)) then <tei:author key="A002068">Weber, Carl Maria von</tei:author> (: Sonderbehandlung fürs Tagebuch :)
     else ( 
-        $doc//mei:titleStmt/mei:respStmt/mei:persName[@role = ('cmp', 'aut', 'lbt')] |
+        $doc//mei:fileDesc/mei:titleStmt/mei:respStmt/mei:persName[@role = ('cmp', 'aut', 'lbt')] |
         $doc//tei:fileDesc/tei:titleStmt/tei:author
     )
 };

diff --git a/testing/expected-results/works/A020003.html b/testing/expected-results/works/A020003.html
diff --git a/testing/expected-results/works/A020053.html b/testing/expected-results/works/A020053.html
diff --git a/testing/expected-results/works/A020543.html b/testing/expected-results/works/A020543.html
diff --git a/testing/expected-results/works/A020656.html b/testing/expected-results/works/A020656.html
diff --git a/testing/expected-results/works/A020674.html b/testing/expected-results/works/A020674.html
diff --git a/testing/urls/works.txt b/testing/urls/works.txt
@@ -0,0 +1,5 @@
+http://localhost:8080/exist/apps/WeGA-WebApp/A020543.html
+http://localhost:8080/exist/apps/WeGA-WebApp/A020656.html
+http://localhost:8080/exist/apps/WeGA-WebApp/A020003.html
+http://localhost:8080/exist/apps/WeGA-WebApp/A020053.html
+http://localhost:8080/exist/apps/WeGA-WebApp/A020674.html