Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating catch to cache2 latest release. #28

Merged
merged 6 commits into from
Aug 16, 2022
Merged

Conversation

tinselcity
Copy link
Contributor

What

  • fixes for building on 22.04 with gcc/g++ 11.2.0 stock compilers

Error was from older version of catch.hpp

In file included from /usr/include/signal.h:328,
                 from /home/rmorrison/gproj/is2/ext/catch/catch.hpp:6230,
                 from /home/rmorrison/gproj/is2/tests/whitebox/_catch.cc:16:
/home/rmorrison/gproj/is2/ext/catch/catch.hpp:6253:33: error: size of array ‘altStackMem’ is not an integral constant-expression
 6253 |         static char altStackMem[SIGSTKSZ];
      |                                 ^~~~~~~~
/home/rmorrison/gproj/is2/ext/catch/catch.hpp:6304:45: error: size of array ‘altStackMem’ is not an integral constant-expression
 6304 |     char FatalConditionHandler::altStackMem[SIGSTKSZ] = {};
      |                

Described in:
catchorg/Catch2#2178
Seems to be related to glibc change:
https://sourceware.org/git/?p=glibc.git;a=commit;h=6c57d320484988e87e446e2e60ce42816bf51d53

@airencracken
Copy link

Did you mean catch2? heh

Copy link

@airencracken airencracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tinselcity tinselcity merged commit 97bc1a2 into master Aug 16, 2022
@tinselcity tinselcity deleted the fixes_for_22_04 branch August 16, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants