Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the go version to 1.22 #833

Merged
merged 11 commits into from
Mar 6, 2024
Merged

updated the go version to 1.22 #833

merged 11 commits into from
Mar 6, 2024

Conversation

p-mega
Copy link
Contributor

@p-mega p-mega commented Feb 28, 2024

What this PR does / why we need it:

The purpose of this PR is to upgrade the version of go to 1.22

Will this PR make the community happier?

Yes

Which issue this PR fixes:

fixes #822

How is this PR tested

  • unit test
  • e2e test

Special notes for your reviewer:

Release note:

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.41%. Comparing base (8a0cc59) to head (b8dfa82).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #833       +/-   ##
===========================================
- Coverage   54.78%   37.41%   -17.38%     
===========================================
  Files          23       46       +23     
  Lines        2287     3544     +1257     
===========================================
+ Hits         1253     1326       +73     
- Misses        919     2103     +1184     
  Partials      115      115               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rhoninl rhoninl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kris21he kris21he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

37.41% (-17.38%) downgrage on ut coverage?

Copy link
Contributor

@kris21he kris21he left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kris21he kris21he merged commit a578cb8 into main Mar 6, 2024
14 of 15 checks passed
@kris21he kris21he deleted the update_go_version branch March 6, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump go version to 1.22
5 participants