Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1123] Fix LwM2M example for Gateway #1142

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

Chi-Kai
Copy link
Contributor

@Chi-Kai Chi-Kai commented Feb 27, 2025

What this PR does / why we need it:

Will this PR make the community happier?

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

Apologies, I have already revised the commit history.

Copy link
Collaborator

@rhoninl rhoninl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomqin93 tomqin93 requested a review from Copilot March 4, 2025 04:54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.20%. Comparing base (eb8ea86) to head (c0ab0f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   33.10%   33.20%   +0.10%     
==========================================
  Files          55       55              
  Lines        4864     4864              
==========================================
+ Hits         1610     1615       +5     
+ Misses       3114     3110       -4     
+ Partials      140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomqin93 tomqin93 merged commit 151220c into Edgenesis:main Mar 5, 2025
6 checks passed
@tomqin93
Copy link
Contributor

tomqin93 commented Mar 5, 2025

@Chi-Kai Thanks for this PR! Please reach out to info@edgenesis.com for a bag of goodies :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants