Add vimeo/psalm as new tool #87
Conversation
| @@ -0,0 +1,40 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Great idea to define XML template in twig!
composer.lock
Outdated
| @@ -4,8 +4,7 @@ | |||
| "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file", | |||
There was a problem hiding this comment.
Please revert changes in composer.lock.
I know that lock file is not up to date. I'll update before releasing a new version.
| 'psalm' => array( | ||
| 'optionSeparator' => '=', | ||
| 'xml' => ['psalm.xml'], | ||
| 'errorsXPath' => '//item/severity[text()=\'error\']', |
There was a problem hiding this comment.
Add internalClass. It prevents running a suggested tool when the tool is not installed.
phpqa should quietly ignore the tool, not show an error message:
# bad
$ ./phpqa --verbose --report --config tests/.travis --tools psalm
[FileSystem\CleanDir] Cleaned build/
[FileSystem\FilesystemStack] mkdir ["build\/"]
[Edge\QA\Task\ParallelExec] "/phpqa-psalm/vendor/bin/psalm" --config="build/psalm-config.xml" --output-format=console --show-info=true --report="build//psalm.xml"
1/1 [============================] 100%
[Edge\QA\Task\ParallelExec] Output for "/phpqa-psalm/vendor/bin/psalm" --config="build/psalm-config.xml" --output-format=console --show-info=true --report="build//psalm.xml"
sh: 1: /phpqa-psalm/vendor/bin/psalm: not found
# good
$ ./phpqa --verbose --report --config tests/.travis --tools psalm
[FileSystem\CleanDir] Cleaned build/
[FileSystem\FilesystemStack] mkdir ["build\/"]
0 [>---------------------------]
[Edge\QA\Task\ParallelExec] 0 processes finished running
[Edge\QA\Task\ParallelExec] Done in 0sAfter that you can add psalm to bin/ci.sh (it will be tested in php 7.1)
| ) | ||
| ); | ||
| $psalmConfigFile = escapePath($psalmConfigFile); | ||
| } |
There was a problem hiding this comment.
Add documentation (#suggested tools (stable status), #output modes, #advanced configuration).
Please mention in psalm.config that analyzedDirs and ignoredDirs are not used when custom config is specified (you can copy-paste it from phpunit.config).
|
@zdenekdrahos Is it good or you need more? |
|
Perfect! |
Closes #85