Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - fix phpstan/psalm config #236

Merged
merged 3 commits into from
May 14, 2021
Merged

Conversation

zdenekdrahos
Copy link
Member

@zdenekdrahos zdenekdrahos commented May 14, 2021

  • phpstan - use level that does not require type hint for everything, don't use deprecated config
  • psalm - fix phpunit testcase alias, use level that does not require type hint for everything

Checking exit code can't be reverted to zero, because php7.2 without updated dependencies does not work:

  • old psalm version causes The attribute 'errorLevel' is not allowed.
  • phpstan + phpmetrics v1 = Hoa main file (Core.php) must be included once.

psalm error
phpstan error

- use level that does not require type hint for everything, ignore
- don't use deprecated config (https://github.com/EdgedesignCZ/phpqa/runs/2475678048?check_suite_focus=true#step:7:757)
@zdenekdrahos zdenekdrahos force-pushed the static-analyzers-20210514 branch from 34e0996 to 87504c9 Compare May 14, 2021 06:49
@zdenekdrahos zdenekdrahos force-pushed the static-analyzers-20210514 branch from 8f254ea to 94a00d9 Compare May 14, 2021 07:31
- use level that does not require type hint for everything
- cleanup ignored rules
@zdenekdrahos zdenekdrahos marked this pull request as ready for review May 14, 2021 07:53
@zdenekdrahos zdenekdrahos merged commit ffb94c0 into master May 14, 2021
@zdenekdrahos zdenekdrahos deleted the static-analyzers-20210514 branch May 14, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant