#205 - Bumps consolidation/robo to ~2, and handle symfony/process>3.4 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yondz
changed the title
Yondz
force-pushed
the
add_symfony_5_compatibility
branch
2 times, most recently
from
db3b52a to
3242c41
Compare
…/process prototype change
Yondz
force-pushed
the
add_symfony_5_compatibility
branch
from
3242c41 to
4090eb3
Compare
Yondz
changed the title
Merged
9 tasks
Closed
|
It's going to be fixed in 148151c (php 7.4 test).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
Here's an attempt to bring Symfony 5 compat to phpqa without having to clone it in a separate dir (which worked well btw) or using a commited robo.phar
As I'm not sure at all if it's the proper way to fix this (it sounds like a workaround), or your contribution process itself, I'll be waiting your feedbacks :)
Btw, we are still supporting php>5.4, robo 0.x and symfony 2.8, is it still necessary ? maybe it would be simpler to maintain & cleaner to just bumps everything to at least maintained version (like PHP 7.x, SF 4.x & so on) ? Would it be something we should start working on ?
Thanks, see ya :)