CI - build docker in php 7.2, upgrade phpstan, hotfix php-cs-fixer, add php 7.4 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zdenekdrahos
commented
Dec 8, 2019
•
zdenekdrahos
commented
- docker + php 7.2
- phpstan 0.12 in version with symfony2 components (it requires php 7.1)
- hotfix php 7.2 + php-cs-fixer + travis (it works in docker, but travis causes weird errors) -> improve handling xml errors, ignore php-cs-fixer & phpmetrics conflict
- add php 7.4 - fix twig errors
Docker image has php 7.2 6ef3519 $ docker run --rm -it zdenekdrahos/phpqa:v1.23.3 php -v PHP 7.2.12 (cli)
…s php 7.2 https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622261274#L1823 https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v2.2.20/php-cs-fixer#L28 It's not caused by php 7.2.22, something else is wrong... https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622265515 https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622267530#L721 https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622270345 https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622271457 https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622272539 https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622274667#L1082
https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622274667#L1833 simplexml_load_file(): build//phpstan.xml:1: parser error : Start tag expec
Summary should be shown, no fatal error. It should suppress php-cs-fixer errors on php 7.2. https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622282695#L2241 https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622261274#L1823 https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622274667#L1833
Still don't know why php-cs-fixer xml causes errors. https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622290077#L2265 It's caused by (unset) cast https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622293431#L2325
https://travis-ci.org/EdgedesignCZ/phpqa/jobs/622280212 [Twig\Error\SyntaxError] An exception has been thrown during the compilation of a template ("Unparen thesized `a ? b : c ? d : e` is deprecated. Use either `(a ? b : c) ? d : e ` or `a ? b : (c ? d : e)`") in "cli.html.twig". It might need twig v1.42.3 that dropped php 5.4 support https://github.com/twigphp/Twig/blob/v1.42.4/CHANGELOG#L6
zdenekdrahos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.