Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PHP 7.2 on Travis #106

Merged
merged 3 commits into from
Feb 3, 2018
Merged

Test PHP 7.2 on Travis #106

merged 3 commits into from
Feb 3, 2018

Conversation

zdenekdrahos
Copy link
Member

No description provided.

https://travis-ci.org/EdgedesignCZ/phpqa/jobs/336877235

Don't use assertEquals
PHP Fatal error:  Declaration of SebastianBergmann\Comparator\DOMNodeComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false) must be compatible with SebastianBergmann\Comparator\ObjectComparator::assertEquals($expected, $actual, $delta = 0, $canonicalize = false, $ignoreCase = false, array &$processed = Array) in /vendor/sebastian/comparator/src/DOMNodeComparator.php on line 110

Updating phpunit sucks because of internal libraries used in phpcpd/phploc
sebastianbergmann/phpcpd#152
composer remove phpunit/phpunit --dev
composer require phpunit/phpunit:~5.7 --dev

    - Conclusion: remove phpunit/php-timer 2.0.0
    - Installation request for phpunit/phpunit ~5.7 -> satisfiable by phpunit/phpunit[5.7.0, 5.7.1, 5.7.10, 5.7.11, 5.7.12, 5.7.13, 5.7.14, 5.7.15, 5.7.16, 5.7.17, 5.7.18, 5.7.19, 5.7.2, 5.7.20, 5.7.21, 5.7.22, 5.7.23, 5.7.24, 5.7.25, 5.7.26, 5.7.27, 5.7.3, 5.7.4, 5.7.5, 5.7.6, 5.7.7, 5.7.8, 5.7.9].
    - Conclusion: don't install phpunit/php-timer 2.0.0
    - phpunit/phpunit 5.7.0 requires phpunit/php-timer ^1.0.6 -> satisfiable by phpunit/php-timer[1.0.6, 1.0.7, 1.0.8, 1.0.9].
@zdenekdrahos zdenekdrahos removed the wip label Feb 3, 2018
@zdenekdrahos zdenekdrahos merged commit 4e58a6d into master Feb 3, 2018
@zdenekdrahos zdenekdrahos deleted the php-7.2 branch February 3, 2018 09:37
zdenekdrahos added a commit that referenced this pull request Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant