fix(color): attempt to show units for value widget if height < 50 - 2.10

[mha1]

Fixes the issue were the value widget wouldn't display units in any of the four row screen layouts.

[pfeerick]

I think the fault may be stemming from checking the height rather the width when making the decision to drop the units, as you might have lots of long (so plenty of space to show the unit) but not very tall rows... so might tinker with this a bit more.

btw, main form is preferred if it can be cherry-picked (this is not) or trivial to convert (this should be). But I did put you one the spot 😆

[mha1]

I think the fault may be stemming from checking the height rather the width when making the decision to drop the units, as you might have lots of long (so plenty of space to show the unit) but not very tall rows... so might tinker with this a bit more.

btw, main form is preferred if it can be cherry-picked (this is not) or trivial to convert (this should be). But I did put you one the spot 😆

Your extensions is technically correct but I think it might be somewhat academical. The no unit case only happens in single line mode of the value widget (height < 50, meaning 4 row layouts). This means the no unit case only happens on landscape radios because portrait radios show the value widget with separate lines for label and value (width is always > 50). But on landscape radios the width is always >= 120. Or can you think of a situation where the width is < 120 in single line mode?

Btw: Due to the fact portrait radios always show units (because height > 50, two lines) they are clipped if the value is to long (which I think is more acceptable than generally showing no units). One more argument against your commit. Better display units and clip them if there's not enough space rather than not displaying units at all.

Anyhow, thanks for looking into this.

PS: I don't mind being on the spot but you asked for 2.10.6 and a main PR couldn't be cherry picked ...

[pfeerick]

But on landscape radios the width is always >= 120. Or can you think of a situation where the width is < 120 in single line mode?

And what happens if/when a three column layout is added?

Btw: Due to the fact portrait radios always show units (because height > 50, two lines) they are clipped if the value is to long (which I think is more acceptable than generally showing no units). One more argument against your commit.

Which is exactly why I did it that way... it should not trigger on 320x480 radios, since the width is only checked if height() < 50. Good enough for 2.10. For main, really should consider checking the length of value being displayed and dropping the unit if too long, but not sure if I can really be bothered going that far. Starting to get into the territory of marquee/scrolling to fit to small a space....

[mha1]

And what happens if/when a three column layout is added?

It'd clip the display just as it does now on NV14. Yeah, best would be to decide if the unit fits and only display it if it does. Second best is to show the units in any case and clip it, worst is to not show it at all.

[3djc]

I think clipping is worst that not displaying unit, which you usually know very well anyway

[mha1]

I think clipping is worst that not displaying unit, which you usually know very well anyway

I was assisting a beginner. He wasn't happy because the labels are not very explicit. After explaining RxBt it was clear it is a voltage but it required explaining.

And clipping would not happen in most of the cases. Not doing clipping in favor of no unit would just throw away a lot of good displays in favor of maybe one or two potentially too long readings.

[pfeerick]

Yeah, I get both POV... one does not look so nice and the other is not making the most of the display area/potentially not as self-descriptive as it could be. I guess I'm looking at it *knowing* what the unit is, and thinking losing it isn't a big deal. Fair enough, will roll that back.

…

On Wed, Jan 22, 2025 at 8:12 PM Michael ***@***.***> wrote: I think clipping is worst that not displaying unit, which you usually know very well anyway I was assisting a beginner. He wasn't happy because the labels are not very explicit. After explaining RxBt it was clear it is a voltage but it required explaining. And clipping would not happen in most of the cases. Not doing clipping in favor of no unit would just throw away a lot of good displays in favor of maybe one or two potentially too long readings. — Reply to this email directly, view it on GitHub <#5811 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJ66KMMELG67PHQ5ZTIND32L5VIPAVCNFSM6AAAAABVSDTQOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBWHAYTMOJYHA> . You are receiving this because you commented.Message ID: ***@***.***>